fix: remove stale cache entries when last observer unsubscribes#4569
Closed
tenderdeve wants to merge 1 commit intowevm:mainfrom
Closed
fix: remove stale cache entries when last observer unsubscribes#4569tenderdeve wants to merge 1 commit intowevm:mainfrom
tenderdeve wants to merge 1 commit intowevm:mainfrom
Conversation
…#4390) When all listeners for an observerId unsubscribe, delete the entries from listenersCache and cleanupCache instead of leaving empty arrays that accumulate indefinitely in long-running processes.
|
@tenderdeve is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4390
When all listeners for an
observerIdcallunwatch(), theunsubscribefunction previously filtered them out but left an empty array behind inlistenersCache(and a stale entry incleanupCache). In long-running servers creating many short-lived clients, these empty entries accumulate indefinitely.The fix deletes both cache entries when the last listener unsubscribes, instead of storing an empty array.
I also added a test that explicitly verifies cache cleanup — it checks that both
listenersCacheandcleanupCachestill have entries while listeners remain, and are fully deleted after the lastunwatch()call.