WV-2664: Persist heart like/dislike icon and keep support tally in sync#4859
Merged
Merged
Conversation
- OrganizationStore optimistically mirrors the server's first-action-wins coupling, and organizationsFollowedRetrieve now rebuilds the politician follow/dislike lists from server truth so stale optimistic entries get reconciled (not just appended). - ItemActionBar optimistically bumps the campaign tally only on a genuine clean-slate first action, gated on the follow lists being hydrated to avoid over-counting an already-hearted voter. - HeartFavoriteToggleLive syncs counts live, floors them at 0, no-ops redundant actions, and no longer leaves the complete-your-profile modal stuck open. - CampaignSupportThermometer reads the voter's current stance from SupportStore; CampaignStore preserves an explicit 0 supporters/opposers count.
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: The heart (like/dislike) and the Choose/Oppose position are now independent soclicking one no longer secretly flips the other. Support counts stay accurate and update live, and a batch of loading-race glitches are gone: phantom +1 counts, a heart stuck in the wrong state, and a frozen "complete your profile" popup.