Add health repository

This follows the convention in the rest of the application and allows us to
easily mock it for tests.

Author: rolandgeider

lib/features/health/models/health_reading.dart

@@ -0,0 +1,59 @@
+/*
+ * This file is part of wger Workout Manager <https://github.com/wger-project>.
+ * Copyright (c) 2026 wger Team
+ *
+ * wger Workout Manager is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import 'package:health/health.dart';
+
+/// A single reading pulled from a health platform, reduced to the fields the
+/// importer needs. Keeps the `health` package's [HealthDataPoint] out of the
+/// notifier so the sync logic can be tested with plain values.
+class HealthReading {
+  const HealthReading({
+    required this.type,
+    required this.value,
+    required this.date,
+    this.externalId,
+  });
+
+  /// The platform type this reading belongs to (matched against
+  /// `HealthMetric.dataType`).
+  final HealthDataType type;
+
+  /// Numeric value in the platform's native unit.
+  final double value;
+
+  /// Start of the reading.
+  final DateTime date;
+
+  /// Platform record UUID for deduplication; `null` when the platform gives none.
+  final String? externalId;
+
+  /// Builds a reading from a platform data point, or `null` for a non-numeric
+  /// point (which the importer cannot store).
+  static HealthReading? fromDataPoint(HealthDataPoint point) {
+    final value = point.value;
+    if (value is! NumericHealthValue) {
+      return null;
+    }
+    return HealthReading(
+      type: point.type,
+      value: value.numericValue.toDouble(),
+      date: point.dateFrom,
+      externalId: point.uuid.isEmpty ? null : point.uuid,
+    );
+  }
+}

lib/features/health/providers/health_repository.dart

@@ -0,0 +1,84 @@
+/*
+ * This file is part of wger Workout Manager <https://github.com/wger-project>.
+ * Copyright (c) 2026 wger Team
+ *
+ * wger Workout Manager is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import 'dart:io';
+
+import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:health/health.dart';
+import 'package:logging/logging.dart';
+import 'package:wger/features/health/models/health_reading.dart';
+
+final healthRepositoryProvider = Provider<HealthRepository>((ref) {
+  return HealthRepository();
+});
+
+/// Wraps the `health` plugin so the rest of the app talks to a small, mockable
+/// surface instead of Apple Health / Health Connect directly.
+class HealthRepository {
+  HealthRepository([Health? health]) : _health = health ?? Health();
+
+  final Health _health;
+  final _logger = Logger('HealthRepository');
+
+  /// Identifies which platform a reading came from.
+  String get sourceName => Platform.isIOS ? 'apple_health' : 'health_connect';
+
+  /// Whether a health platform is usable on this device.
+  Future<bool> isAvailable() async {
+    if (Platform.isAndroid) {
+      await _health.configure();
+      final status = await _health.getHealthConnectSdkStatus();
+      return status == HealthConnectSdkStatus.sdkAvailable;
+    }
+    return Platform.isIOS;
+  }
+
+  /// Ensures READ access to [types] (requesting it if needed) and, on Android,
+  /// access to historical data. Returns whether access is granted.
+  Future<bool> ensureAuthorized(List<HealthDataType> types) async {
+    await _health.configure();
+    final access = List.filled(types.length, HealthDataAccess.READ);
+
+    final hasPerms = await _health.hasPermissions(types, permissions: access);
+    if (hasPerms != true) {
+      final granted = await _health.requestAuthorization(types, permissions: access);
+      if (!granted) {
+        _logger.warning('Health permissions not granted');
+        return false;
+      }
+    }
+
+    if (Platform.isAndroid) {
+      await _health.requestHealthDataHistoryAuthorization();
+    }
+    return true;
+  }
+
+  /// Reads all [types] between [start] and [end], platform-deduplicated and
+  /// reduced to numeric [HealthReading]s.
+  Future<List<HealthReading>> read({
+    required List<HealthDataType> types,
+    required DateTime start,
+    required DateTime end,
+  }) async {
+    final points = _health.removeDuplicates(
+      await _health.getHealthDataFromTypes(types: types, startTime: start, endTime: end),
+    );
+    return points.map(HealthReading.fromDataPoint).whereType<HealthReading>().toList();
+  }
+}

lib/features/health/providers/health_sync.dart

@@ -16,15 +16,14 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-import 'dart:io';
-
 import 'package:collection/collection.dart';
 import 'package:health/health.dart';
 import 'package:logging/logging.dart';
 import 'package:powersync/powersync.dart' as ps;
 import 'package:riverpod_annotation/riverpod_annotation.dart';
 import 'package:wger/core/shared_preferences.dart';
 import 'package:wger/features/health/models/health_metric.dart';
+import 'package:wger/features/health/providers/health_repository.dart';
 import 'package:wger/features/measurements/models/measurement_category.dart';
 import 'package:wger/features/measurements/models/measurement_entry.dart';
 import 'package:wger/features/measurements/providers/measurement_repository.dart';
@@ -52,25 +51,22 @@ class HealthSyncState {
 }
 
 /// Imports body metrics from Apple Health / Health Connect into measurement
-/// categories. Read-only: reads the platform, writes to the local Drift DB, and
-/// lets PowerSync push the rows up. Re-imports are deduplicated via each
-/// measurement's [MeasurementEntry.externalId] (the platform record UUID).
+/// categories. Read-only: reads the platform (via [HealthRepository]), writes to
+/// the local Drift DB, and lets PowerSync push the rows up. Re-imports are
+/// deduplicated via each measurement's [MeasurementEntry.externalId] (the
+/// platform record UUID).
 @Riverpod(keepAlive: true)
 class HealthSyncNotifier extends _$HealthSyncNotifier {
   final _logger = Logger('HealthSyncNotifier');
-  late final Health _health;
-  late final MeasurementRepository _repo;
+  late final HealthRepository _health;
+  late final MeasurementRepository _measurements;
 
   List<HealthDataType> get _types => enabledHealthMetrics.map((m) => m.dataType).toList();
 
-  List<HealthDataAccess> get _readAccess => List.filled(_types.length, HealthDataAccess.READ);
-
-  String get _sourceName => Platform.isIOS ? 'apple_health' : 'health_connect';
-
   @override
   HealthSyncState build() {
-    _health = Health();
-    _repo = ref.read(measurementRepositoryProvider);
+    _health = ref.read(healthRepositoryProvider);
+    _measurements = ref.read(measurementRepositoryProvider);
     _loadPersistedState();
     return const HealthSyncState();
   }
@@ -82,33 +78,16 @@ class HealthSyncNotifier extends _$HealthSyncNotifier {
   }
 
   /// Whether a health platform is available on this device.
-  Future<bool> isAvailable() async {
-    if (Platform.isAndroid) {
-      await _health.configure();
-      final status = await _health.getHealthConnectSdkStatus();
-      return status == HealthConnectSdkStatus.sdkAvailable;
-    }
-    return Platform.isIOS;
-  }
+  Future<bool> isAvailable() => _health.isAvailable();
 
   /// Requests permissions, persists the preference, and runs an initial import.
   Future<int> enableSync() async {
     _logger.info('Enabling health sync');
-    await _health.configure();
-
-    final authorized = await _health.requestAuthorization(_types, permissions: _readAccess);
-    if (!authorized) {
-      _logger.warning('Health permissions not granted');
+    if (!await _health.ensureAuthorized(_types)) {
       return 0;
     }
-
-    if (Platform.isAndroid) {
-      await _health.requestHealthDataHistoryAuthorization();
-    }
-
     await PreferenceHelper.instance.setHealthSyncEnabled(true);
     state = state.copyWith(isEnabled: true);
-
     return syncOnAppOpen();
   }
 
@@ -133,42 +112,32 @@ class HealthSyncNotifier extends _$HealthSyncNotifier {
     state = state.copyWith(isEnabled: true, isSyncing: true);
 
     try {
-      await _health.configure();
-
-      final hasPerms = await _health.hasPermissions(_types, permissions: _readAccess);
-      if (hasPerms != true) {
-        final authorized = await _health.requestAuthorization(_types, permissions: _readAccess);
-        if (!authorized) {
-          _logger.warning('Health permissions not granted during sync');
-          state = state.copyWith(isSyncing: false);
-          return 0;
-        }
+      if (!await _health.ensureAuthorized(_types)) {
+        _logger.warning('Health permissions not granted during sync');
+        state = state.copyWith(isSyncing: false);
+        return 0;
       }
 
       final lastSyncStr = await prefs.getLastHealthSyncTimestamp();
       final startTime = lastSyncStr != null ? DateTime.parse(lastSyncStr) : DateTime(2000);
       final endTime = DateTime.now();
       _logger.info('Syncing health data from $startTime to $endTime');
 
-      var points = await _health.getHealthDataFromTypes(
-        types: _types,
-        startTime: startTime,
-        endTime: endTime,
-      );
-      points = _health.removeDuplicates(points);
-      if (points.isEmpty) {
+      final readings = await _health.read(types: _types, start: startTime, end: endTime);
+      if (readings.isEmpty) {
         _logger.info('No new health data');
         state = state.copyWith(isSyncing: false, lastSyncCount: 0);
         return 0;
       }
 
-      final categories = await _repo.getAllOnce();
+      final categories = await _measurements.getAllOnce();
+      final source = _health.sourceName;
       var synced = 0;
       DateTime? latest;
 
       for (final metric in enabledHealthMetrics) {
-        final metricPoints = points.where((p) => p.type == metric.dataType);
-        if (metricPoints.isEmpty) {
+        final metricReadings = readings.where((r) => r.type == metric.dataType);
+        if (metricReadings.isEmpty) {
           continue;
         }
 
@@ -178,33 +147,29 @@ class HealthSyncNotifier extends _$HealthSyncNotifier {
             if (e.externalId != null) e.externalId!,
         };
 
-        for (final point in metricPoints) {
-          final value = point.value;
-          if (value is! NumericHealthValue) {
-            continue;
-          }
-          final uuid = point.uuid;
-          if (uuid.isNotEmpty && seen.contains(uuid)) {
+        for (final reading in metricReadings) {
+          final uuid = reading.externalId;
+          if (uuid != null && seen.contains(uuid)) {
             continue;
           }
 
-          await _repo.addLocalDrift(
+          await _measurements.addLocalDrift(
             MeasurementEntry(
               categoryId: category.id!,
-              date: point.dateFrom,
-              value: metric.toCategoryValue(value.numericValue.toDouble()),
+              date: reading.date,
+              value: metric.toCategoryValue(reading.value),
               notes: '',
-              source: _sourceName,
-              externalId: uuid.isEmpty ? null : uuid,
+              source: source,
+              externalId: uuid,
             ),
           );
 
-          if (uuid.isNotEmpty) {
+          if (uuid != null) {
             seen.add(uuid);
           }
           synced++;
-          if (latest == null || point.dateFrom.isAfter(latest)) {
-            latest = point.dateFrom;
+          if (latest == null || reading.date.isAfter(latest)) {
+            latest = reading.date;
           }
         }
       }
@@ -243,7 +208,7 @@ class HealthSyncNotifier extends _$HealthSyncNotifier {
       unit: metric.unit,
       metricType: metric.metricType,
     );
-    await _repo.addLocalDriftCategory(category);
+    await _measurements.addLocalDriftCategory(category);
     categories.add(category);
     return category;
   }