Use the locale consistently

Author: rolandgeider

integration_test/README.md

@@ -1,19 +1,17 @@
 This will generate some screenshots and save them to the Play Store metadata folder.
 
-1) Set the correct value for the device size by setting the `destination` variable
-2) Start the correct emulator and
-   run
+1) Start the correct emulator/simulator for the device size you want.
+2) Run, selecting the device size via `--dart-define=DEVICE_TYPE`:
    ```
    flutter drive \
        --driver=test_driver/screenshot_driver.dart \
        --target=integration_test/make_screenshots_test.dart \
        --dart-define=DEVICE_TYPE=androidPhone
    ```
-   For the values of device type, consult the values of the DeviceType enum in
-   `make_screenshots_test.dart`
-3) flutter drive --driver=test_driver/screenshot_driver.dart --target=integration_test/make_screenshots_test.dart --dart-define=DEVICE_TYPE=androidPhone`
-4) If you get errors or the screenshots are not written to disk, edit the
-   `languages` list and comment some of the languages
+   For the available device types, consult the `DeviceType` enum in
+   `make_screenshots_test.dart`.
+3) If you get errors or the screenshots are not written to disk, edit the
+   `languages` list and comment some of the languages out.
 
 See also
 

integration_test/make_screenshots_test.dart

@@ -162,7 +162,7 @@ void main() {
       // });
 
       testWidgets('gym mode stats screen - $language', (WidgetTester tester) async {
-        await tester.pumpWidget(createGymModeResultsScreen(locale: languageCode));
+        await tester.pumpWidget(createGymModeResultsScreen(locale: locale));
         await tester.pumpAndSettle();
         await takeScreenshot(tester, binding, language, '03 - gym mode');
       });

integration_test/screenshots_03_gym_mode.dart

@@ -94,7 +94,8 @@ Widget createGymModeScreen({Locale? locale}) {
   );
 }
 
-Widget createGymModeResultsScreen({String locale = 'en'}) {
+Widget createGymModeResultsScreen({Locale? locale}) {
+  locale ??= const Locale('en');
   final controller = PageController(initialPage: 0);
 
   final key = GlobalKey<NavigatorState>();
@@ -120,7 +121,7 @@ Widget createGymModeResultsScreen({String locale = 'en'}) {
     ),
 
     child: MaterialApp(
-      locale: Locale(locale),
+      locale: locale,
       debugShowCheckedModeBanner: false,
       localizationsDelegates: AppLocalizations.localizationsDelegates,
       supportedLocales: AppLocalizations.supportedLocales,