Skip to content

fix(nutrition): resolve fl_chart app crash when toggling meal details in Nutritional Plan Detail screen #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolandgeider merged 1 commit into from
May 22, 2026
Merged

fix(nutrition): resolve fl_chart app crash when toggling meal details in Nutritional Plan Detail screen #1202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions lib/widgets/nutrition/charts.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,14 @@ class MealDiaryBarChartWidgetState extends State<MealDiaryBarChartWidget> {
),
);

double _safePercent(double logged, double planned) {
if (planned <= 0 || logged <= 0) return 0.0;
final percent = (logged / planned) * 100;

if (percent.isNaN || percent.isInfinite) return 0.0;
return percent;
}

@override
Widget build(BuildContext context) {
return AspectRatio(
Expand Down Expand Up @@ -573,7 +581,7 @@ class MealDiaryBarChartWidgetState extends State<MealDiaryBarChartWidget> {
barsSpace: barsSpace,
barRods: [
BarChartRodData(
toY: widget._logged.energy / widget._planned.energy * 100,
toY: _safePercent(widget._logged.energy, widget._planned.energy),
color: LIST_OF_COLORS3.first,
width: barsWidth,
),
Expand All @@ -584,7 +592,7 @@ class MealDiaryBarChartWidgetState extends State<MealDiaryBarChartWidget> {
barsSpace: barsSpace,
barRods: [
BarChartRodData(
toY: widget._logged.protein / widget._planned.protein * 100,
toY: _safePercent(widget._logged.protein, widget._planned.protein),
color: LIST_OF_COLORS3.first,
width: barsWidth,
),
Expand All @@ -595,7 +603,10 @@ class MealDiaryBarChartWidgetState extends State<MealDiaryBarChartWidget> {
barsSpace: barsSpace,
barRods: [
BarChartRodData(
toY: widget._logged.carbohydrates / widget._planned.carbohydrates * 100,
toY: _safePercent(
widget._logged.carbohydrates,
widget._planned.carbohydrates,
),
color: LIST_OF_COLORS3.first,
width: barsWidth,
),
Expand All @@ -606,7 +617,7 @@ class MealDiaryBarChartWidgetState extends State<MealDiaryBarChartWidget> {
barsSpace: barsSpace,
barRods: [
BarChartRodData(
toY: widget._logged.fat / widget._planned.fat * 100,
toY: _safePercent(widget._logged.fat, widget._planned.fat),
color: LIST_OF_COLORS3.first,
width: barsWidth,
),
Expand Down
201 changes: 201 additions & 0 deletions test/nutrition/nutritional_meal_charts_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,201 @@
/*
* This file is part of wger Workout Manager <https://github.com/wger-project>.
* Copyright (c) 2026 wger Team
*
* wger Workout Manager is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

import 'package:fl_chart/fl_chart.dart';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:wger/l10n/generated/app_localizations.dart';
import 'package:wger/models/nutrition/nutritional_values.dart';
import 'package:wger/widgets/nutrition/charts.dart';

void main() {
Widget createMealBarChartScreen(NutritionalValues logged, NutritionalValues planned) {
return MaterialApp(
locale: const Locale('en'),
localizationsDelegates: AppLocalizations.localizationsDelegates,
supportedLocales: AppLocalizations.supportedLocales,
home: Scaffold(
body: Center(
child: SizedBox(
height: 300,
width: 300,
child: MealDiaryBarChartWidget(
logged: logged,
planned: planned,
),
),
),
),
);
}

testWidgets('MealDiaryBarChart renders correctly with valid data', (WidgetTester tester) async {
final logged = NutritionalValues.values(
500,
50,
50,
1,
10,
1,
1,
1,
);
final planned = NutritionalValues.values(
1000,
100,
100,
1,
20,
1,
1,
1,
);

await tester.pumpWidget(createMealBarChartScreen(logged, planned));
await tester.pumpAndSettle();

final barChartFinder = find.byType(BarChart);
expect(barChartFinder, findsOneWidget, reason: 'BarChart should be visible');

// Verify the chart calculated 50% for energy (500 / 1000)
final barChart = tester.widget<BarChart>(barChartFinder);
final energyRod = barChart.data.barGroups.firstWhere((group) => group.x == 3).barRods.first;
expect(energyRod.toY, 50.0, reason: 'Energy bar should calculate to 50%');
});

testWidgets('MealDiaryBarChart does not crash when logged meal data are zero', (
WidgetTester tester,
) async {
final loggedZero = NutritionalValues.values(
0,
0,
0,
0,
0,
0,
0,
0,
);

final planned = NutritionalValues.values(
2000,
150,
200,
1,
70,
1,
1,
1,
);

await tester.pumpWidget(createMealBarChartScreen(loggedZero, planned));
await tester.pumpAndSettle();

final barChartFinder = find.byType(BarChart);
expect(
barChartFinder,
findsOneWidget,
reason: 'BarChart should render safely even with 0 logged values',
);

final barChart = tester.widget<BarChart>(barChartFinder);

// Verify all bars are 0.0 as nothing has been logged
for (var group in barChart.data.barGroups) {
expect(
group.barRods.first.toY,
0.0,
reason:
'Bar at index ${group.x} should fallback to 0.0 when logged data is empty to prevent Infinity crashes',
);
}
});

testWidgets('MealDiaryBarChart does not crash when planned macros are zero', (
WidgetTester tester,
) async {
final logged = NutritionalValues.values(
100,
10,
10,
1,
5,
1,
1,
1,
);

final plannedZero = NutritionalValues.values(
0,
0,
0,
0,
0,
0,
0,
0,
);

await tester.pumpWidget(createMealBarChartScreen(logged, plannedZero));
await tester.pumpAndSettle();

final barChartFinder = find.byType(BarChart);
expect(
barChartFinder,
findsOneWidget,
reason: 'BarChart should render safely even with 0 planned values',
);

final barChart = tester.widget<BarChart>(barChartFinder);

// Verify all bars fallback to 0.0 safely instead of Infinity
for (var group in barChart.data.barGroups) {
expect(
group.barRods.first.toY,
0.0,
reason: 'Bar at index ${group.x} should fallback to 0.0 to prevent Infinity crashes',
);
}
});

testWidgets('MealDiaryBarChart does not crash when both planned and logged are zero', (
WidgetTester tester,
) async {
final emptyValues = NutritionalValues.values(
0,
0,
0,
0,
0,
0,
0,
0,
);

await tester.pumpWidget(createMealBarChartScreen(emptyValues, emptyValues));
await tester.pumpAndSettle();

final barChartFinder = find.byType(BarChart);
expect(barChartFinder, findsOneWidget);

final barChart = tester.widget<BarChart>(barChartFinder);
for (var group in barChart.data.barGroups) {
expect(group.barRods.first.toY, 0.0);
}
});
}