Refactor/nutrition meals components#1224
Merged
rolandgeider merged 5 commits intoJun 18, 2026
Merged
Conversation
- Extract date display logic in nutritional plan details - Migrate hardcoded strings to localization files
- Update MealWidget constructor call - Add interaction steps to reveal ingredients section before testing the add button
Member
|
Now that we have merged the offiline mode, we can finally start working on simpler stuff like this! :) |
- revert translation changes in charts and cleanup meal logs - fix for the Meal test
Contributor
Author
|
YEAH! refactoring this meal.dart file was in my todo list for few weeks now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors
widgets/nutrition/meal.dart(MealWidget), extract large inline sections into named sub-components.
Issue/Problem
_MealWidgetState.build()was ~160 lines long, with deeply nestedifblocks for the editing toolbar, divider, ingredient list, total row, and diary section.
Reading and modifying this method required tracking all four
ViewModeconditionssimultaneously.
Changes
Files Changed
lib/providers/nutrition_notifier.dartrecentMealItemsInPlan()toNutritionStatelib/widgets/nutrition/meal.dartlib/widgets/nutrition/nutritional_plan_detail.dartMealWidgetcall-sitesTesting
Please check that the PR fulfills these requirements
dart format .)