Skip to content

Commit afafab0

Browse files
committed
🔧 update (logging): remove emoji prefixes from log messages
1 parent 8f30234 commit afafab0

3 files changed

Lines changed: 21 additions & 15 deletions

File tree

src/controllers/webhookController.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export class WebhookController {
1717
static initializeBackgroundProcessor(): void {
1818
if (!WebhookController.backgroundProcessor) {
1919
WebhookController.backgroundProcessor = new WebhookController();
20-
LogEngine.log('🔄 Background webhook processor initialized');
20+
LogEngine.log('Background webhook processor initialized');
2121
}
2222
}
2323

@@ -34,7 +34,7 @@ export class WebhookController {
3434
const { event, eventId } = req.body;
3535

3636
// Log raw incoming webhook data
37-
LogEngine.debug(`🌐 RAW WEBHOOK RECEIVED:`, {
37+
LogEngine.debug(`RAW WEBHOOK RECEIVED:`, {
3838
eventId,
3939
completeRawData: req.body
4040
});
@@ -48,7 +48,7 @@ export class WebhookController {
4848
// Quick validation only - no heavy processing
4949
const validationResult = this.webhookService.validateEvent(req.body);
5050
if (!validationResult.isValid) {
51-
LogEngine.error(`Event validation failed:`, validationResult.errors);
51+
LogEngine.error(`Event validation failed:`, validationResult.errors);
5252
return res.status(400).json({
5353
error: 'Invalid event structure',
5454
details: validationResult.errors
@@ -71,7 +71,7 @@ export class WebhookController {
7171
// Queue event for background processing (non-blocking)
7272
this.queueEventForBackgroundProcessing(req.body, requestId);
7373

74-
LogEngine.debug(`Immediate response sent`, {
74+
LogEngine.debug(`Immediate response sent`, {
7575
eventId,
7676
requestId,
7777
responseTime: `${responseTime}ms`
@@ -81,7 +81,7 @@ export class WebhookController {
8181

8282
} catch (error) {
8383
const responseTime = Date.now() - startTime;
84-
LogEngine.error(`💥 Error handling webhook: ${error}`);
84+
LogEngine.error(`Error handling webhook: ${error}`);
8585
return res.status(500).json({
8686
error: 'Internal server error',
8787
responseTime: `${responseTime}ms`,
@@ -106,12 +106,12 @@ export class WebhookController {
106106
await this.processEventInBackground(event, requestId);
107107
}
108108
} catch (error) {
109-
LogEngine.error(`💥 Background processing failed:`, {
109+
LogEngine.error(`Background processing failed:`, {
110110
requestId,
111111
eventId: event?.eventId,
112-
error: error instanceof Error ? error.message : 'Unknown error'
113-
});
114-
}
112+
error: error instanceof Error ? error.message : 'Unknown error'
113+
});
114+
}
115115
})();
116116
});
117117
}
@@ -123,7 +123,7 @@ export class WebhookController {
123123
const startTime = Date.now();
124124

125125
try {
126-
LogEngine.debug(`🔄 Background processing started`, {
126+
LogEngine.debug(`Background processing started`, {
127127
eventId: event?.eventId,
128128
requestId
129129
});
@@ -133,15 +133,15 @@ export class WebhookController {
133133
await this.webhookService.processEvent(event);
134134

135135
const processingTime = Date.now() - startTime;
136-
LogEngine.info(`Background processing completed`, {
136+
LogEngine.info(`Background processing completed`, {
137137
eventId: event?.eventId,
138138
requestId,
139139
processingTime: `${processingTime}ms`
140140
});
141141

142142
} catch (error) {
143143
const processingTime = Date.now() - startTime;
144-
LogEngine.error(`💥 Background processing failed:`, {
144+
LogEngine.error(`Background processing failed:`, {
145145
eventId: event?.eventId,
146146
requestId,
147147
processingTime: `${processingTime}ms`,

src/services/redisService.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,15 @@ export class RedisService {
4646
const eventJson = JSON.stringify(event);
4747

4848
// Log the complete transformed event data
49-
LogEngine.debug(`TRANSFORMED WEBHOOK EVENT:`, {
49+
LogEngine.debug(`TRANSFORMED WEBHOOK EVENT:`, {
5050
eventId: event.data?.eventId || 'unknown',
5151
completeTransformedData: event
5252
});
5353

5454
// Use Redis LIST for FIFO queue (LPUSH + BRPOP pattern)
5555
const result = await this.client.lPush(queueName, eventJson);
5656

57-
LogEngine.info(`Event successfully queued: ${event.data?.eventId || 'unknown'} -> ${queueName} (${result} items in queue)`);
57+
LogEngine.info(`Event successfully queued: ${event.data?.eventId || 'unknown'} -> ${queueName} (${result} items in queue)`);
5858
return result;
5959
} catch (err) {
6060
LogEngine.error(`Error publishing event to queue: ${err}`);

src/services/webhookService.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,9 @@ export class WebhookService {
5858
// Atomically claim fingerprint slot (retry with new eventId detection)
5959
// Uses SET NX to combine check+mark into a single atomic operation
6060
const fingerprint = this.generateFingerprint(event);
61+
if (!fingerprint && event.event !== 'url_verification') {
62+
LogEngine.warn(`No fingerprint generated for event ${event.eventId} — falling back to eventId-only dedup`);
63+
}
6164
if (fingerprint) {
6265
const claimed = await this.redisService.claimFingerprint(fingerprint);
6366
if (!claimed) {
@@ -103,6 +106,8 @@ export class WebhookService {
103106
const targetPlatform = config.targetPlatform;
104107
const attachmentMetadata = this.generateAttachmentMetadata(unthreadEvent);
105108

109+
const fingerprint = this.generateFingerprint(unthreadEvent);
110+
106111
const message: RedisQueueMessage = {
107112
platform: "unthread",
108113
targetPlatform,
@@ -113,7 +118,8 @@ export class WebhookService {
113118
originalEvent: unthreadEvent.event,
114119
eventId: unthreadEvent.eventId,
115120
eventTimestamp: unthreadEvent.eventTimestamp,
116-
webhookTimestamp: unthreadEvent.webhookTimestamp
121+
webhookTimestamp: unthreadEvent.webhookTimestamp,
122+
...(fingerprint && { fingerprint })
117123
},
118124
timestamp: Date.now()
119125
};

0 commit comments

Comments
 (0)