Skip to content

Commit 1fedbca

Browse files
committed
fix windows ci
1 parent 9b9765f commit 1fedbca

4 files changed

Lines changed: 34 additions & 1 deletion

File tree

src/iceberg/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ set(ICEBERG_SOURCES
2121
arrow_c_data_util.cc
2222
arrow_c_data_guard_internal.cc
2323
catalog/memory/in_memory_catalog.cc
24+
catalog/session_catalog.cc
2425
catalog/session_context.cc
2526
delete_file_index.cc
2627
expression/aggregate.cc
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one
3+
* or more contributor license agreements. See the NOTICE file
4+
* distributed with this work for additional information
5+
* regarding copyright ownership. The ASF licenses this file
6+
* to you under the Apache License, Version 2.0 (the
7+
* "License"); you may not use this file except in compliance
8+
* with the License. You may obtain a copy of the License at
9+
*
10+
* http://www.apache.org/licenses/LICENSE-2.0
11+
*
12+
* Unless required by applicable law or agreed to in writing,
13+
* software distributed under the License is distributed on an
14+
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
* KIND, either express or implied. See the License for the
16+
* specific language governing permissions and limitations
17+
* under the License.
18+
*/
19+
20+
#include "iceberg/catalog/session_catalog.h"
21+
22+
namespace iceberg {
23+
24+
SessionCatalog::SessionCatalog() = default;
25+
26+
SessionCatalog::~SessionCatalog() = default;
27+
28+
} // namespace iceberg

src/iceberg/catalog/session_catalog.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class Catalog;
4040
/// the caller has an explicit session identity, properties, or credentials.
4141
class ICEBERG_EXPORT SessionCatalog {
4242
public:
43-
virtual ~SessionCatalog() = default;
43+
virtual ~SessionCatalog();
4444

4545
/// \brief Catalog name.
4646
virtual std::string_view name() const = 0;
@@ -57,6 +57,9 @@ class ICEBERG_EXPORT SessionCatalog {
5757
/// `SessionContext::session_id`. Returned catalog views use the normal
5858
/// `Catalog` interface for all table and namespace operations.
5959
virtual Result<std::shared_ptr<Catalog>> WithContext(SessionContext context) = 0;
60+
61+
protected:
62+
SessionCatalog();
6063
};
6164

6265
} // namespace iceberg

src/iceberg/meson.build

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ iceberg_sources = files(
4444
'arrow_c_data_guard_internal.cc',
4545
'arrow_c_data_util.cc',
4646
'catalog/memory/in_memory_catalog.cc',
47+
'catalog/session_catalog.cc',
4748
'catalog/session_context.cc',
4849
'delete_file_index.cc',
4950
'expression/aggregate.cc',

0 commit comments

Comments
 (0)