fix ubsan

Author: wgtmac

src/iceberg/update/update_properties.cc

@@ -19,8 +19,10 @@
 
 #include "iceberg/update/update_properties.h"
 
+#include <charconv>
 #include <cstdint>
 #include <memory>
+#include <system_error>
 
 #include "iceberg/metrics_config.h"
 #include "iceberg/result.h"
@@ -83,21 +85,23 @@ Result<PendingUpdate::ApplyResult> UpdateProperties::Apply() {
 
   auto iter = updates_.find(TableProperties::kFormatVersion.key());
   if (iter != updates_.end()) {
-    try {
-      int parsed_version = std::stoi(iter->second);
-      if (parsed_version > TableMetadata::kSupportedTableFormatVersion) {
-        return InvalidArgument(
-            "Cannot upgrade table to unsupported format version: v{} (supported: v{})",
-            parsed_version, TableMetadata::kSupportedTableFormatVersion);
-      }
-      format_version_ = static_cast<int8_t>(parsed_version);
-    } catch (const std::invalid_argument& e) {
-      return InvalidArgument("Invalid format version '{}': not a valid integer",
-                             iter->second);
-    } catch (const std::out_of_range& e) {
-      return InvalidArgument("Format version '{}' is out of range", iter->second);
+    int parsed_version = 0;
+    const auto& val = iter->second;
+    auto [ptr, ec] = std::from_chars(val.data(), val.data() + val.size(), parsed_version);
+
+    if (ec == std::errc::invalid_argument) {
+      return InvalidArgument("Invalid format version '{}': not a valid integer", val);
+    } else if (ec == std::errc::result_out_of_range) {
+      return InvalidArgument("Format version '{}' is out of range", val);
     }
 
+    if (parsed_version > TableMetadata::kSupportedTableFormatVersion) {
+      return InvalidArgument(
+          "Cannot upgrade table to unsupported format version: v{} (supported: v{})",
+          parsed_version, TableMetadata::kSupportedTableFormatVersion);
+    }
+    format_version_ = static_cast<int8_t>(parsed_version);
+
     updates_.erase(iter);
   }