address feedback

Author: wgtmac

src/iceberg/table.h

@@ -145,7 +145,8 @@ class ICEBERG_EXPORT Table : public std::enable_shared_from_this<Table> {
   std::unique_ptr<class TableMetadataCache> metadata_cache_;
 };
 
-class ICEBERG_EXPORT StagedTable : public Table {
+/// \brief A table created by stage-create and not yet committed.
+class ICEBERG_EXPORT StagedTable final : public Table {
  public:
   static Result<std::shared_ptr<StagedTable>> Make(
       TableIdentifier identifier, std::shared_ptr<TableMetadata> metadata,
@@ -162,7 +163,9 @@ class ICEBERG_EXPORT StagedTable : public Table {
   using Table::Table;
 };
 
-class ICEBERG_EXPORT StaticTable : public Table {
+/// \brief A read-only table.
+
+class ICEBERG_EXPORT StaticTable final : public Table {
  public:
   static Result<std::shared_ptr<StaticTable>> Make(
       TableIdentifier identifier, std::shared_ptr<TableMetadata> metadata,

src/iceberg/table_metadata.h

@@ -419,13 +419,13 @@ class ICEBERG_EXPORT TableMetadataBuilder : public ErrorCollector {
   /// \return A Result containing the constructed TableMetadata or an error
   Result<std::unique_ptr<TableMetadata>> Build();
 
-  /// \brief Return the changes made to the table metadata
+  /// \brief Returns the changes made to the table metadata
   const std::vector<std::unique_ptr<TableUpdate>>& changes() const;
 
-  /// \brief Return the base metadata without any changes
+  /// \brief Returns the base metadata without any changes
   const TableMetadata* base() const;
 
-  /// \brief Return the current metadata with staged changes applied
+  /// \brief Returns the current metadata with staged changes applied
   const TableMetadata* current() const;
 
   /// \brief Destructor

src/iceberg/transaction.h

@@ -43,7 +43,7 @@ class ICEBERG_EXPORT Transaction : public std::enable_shared_from_this<Transacti
   /// \brief Return the Table that this transaction will update
   const std::shared_ptr<Table>& table() const { return table_; }
 
-  /// \brief Return the base metadata without any changes
+  /// \brief Returns the base metadata without any changes
   const TableMetadata* base() const;
 
   /// \brief Return the current metadata with staged changes applied

src/iceberg/update/update_properties.cc

@@ -78,7 +78,7 @@ UpdateProperties& UpdateProperties::Remove(const std::string& key) {
 Result<PendingUpdate::ApplyResult> UpdateProperties::Apply() {
   ICEBERG_RETURN_UNEXPECTED(CheckErrors());
 
-  const auto* base_metadata = transaction_->base();
+  const auto* base_metadata = transaction_->current();
   if (!base_metadata) {
     return InvalidArgument("Base table metadata is required to apply property updates");
   }
@@ -112,8 +112,7 @@ Result<PendingUpdate::ApplyResult> UpdateProperties::Apply() {
 
   ApplyResult result;
   if (!updates_.empty()) {
-    result.updates.emplace_back(
-        std::make_unique<table::SetProperties>(std::move(updates_)));
+    result.updates.emplace_back(std::make_unique<table::SetProperties>(updates_));
   }
   if (!removals_.empty()) {
     result.updates.emplace_back(std::make_unique<table::RemoveProperties>(