address comments

Author: wgtmac

src/iceberg/test/struct_like_set_test.cc

@@ -154,6 +154,17 @@ TEST(StructLikeSetTest, InsertAndContains) {
   EXPECT_THAT(set.Contains(row3), HasValue(::testing::Eq(false)));
 }
 
+TEST(StructLikeSetTest, InsertAndContainsWithCustomArenaInitialSize) {
+  auto type = MakeStructType({{"id", int32()}, {"name", string()}});
+  StructLikeSet set(type, 8);
+
+  std::string name = "alice";
+  SimpleStructLike row({Scalar{int32_t{1}}, Scalar{std::string_view(name)}});
+
+  ASSERT_THAT(set.Insert(row), IsOk());
+  EXPECT_THAT(set.Contains(row), HasValue(::testing::Eq(true)));
+}
+
 TEST(StructLikeSetTest, DuplicateInsert) {
   auto type = MakeStructType({{"id", int32()}});
   StructLikeSet set(type);

src/iceberg/util/struct_like_set.cc

@@ -216,7 +216,7 @@ std::string_view ScalarTypeName(const Scalar& scalar) {
           [](int64_t) -> std::string_view { return "int64"; },
           [](float) -> std::string_view { return "float"; },
           [](double) -> std::string_view { return "double"; },
-          [](std::string_view) -> std::string_view { return "string_view"; },
+          [](std::string_view) -> std::string_view { return "string"; },
           [](const Decimal&) -> std::string_view { return "decimal"; },
           [](const std::shared_ptr<StructLike>&) -> std::string_view { return "struct"; },
           [](const std::shared_ptr<ArrayLike>&) -> std::string_view { return "list"; },
@@ -467,7 +467,8 @@ Result<bool> ScalarEqual(const Scalar& lhs, const Scalar& rhs) {
 }  // namespace
 
 template <bool kValidate>
-StructLikeSet<kValidate>::StructLikeSet(const StructType& type) {
+StructLikeSet<kValidate>::StructLikeSet(const StructType& type, size_t arena_initial_size)
+    : arena_(arena_initial_size) {
   field_types_.reserve(type.fields().size());
   for (const auto& field : type.fields()) {
     field_types_.push_back(field.type());

src/iceberg/util/struct_like_set.h

@@ -47,8 +47,11 @@ namespace iceberg {
 template <bool kValidate = true>
 class ICEBERG_TEMPLATE_CLASS_EXPORT StructLikeSet {
  public:
+  static constexpr size_t kDefaultArenaInitialSize = 64 * 1024;
+
   /// \brief Create a StructLikeSet for the given struct type.
-  explicit StructLikeSet(const StructType& type);
+  explicit StructLikeSet(const StructType& type,
+                         size_t arena_initial_size = kDefaultArenaInitialSize);
 
   ~StructLikeSet();
 
@@ -94,7 +97,7 @@ class ICEBERG_TEMPLATE_CLASS_EXPORT StructLikeSet {
   std::string_view CopyToArena(std::string_view src) const;
 
   std::vector<std::shared_ptr<Type>> field_types_;
-  mutable std::pmr::monotonic_buffer_resource arena_{64 * 1024};
+  mutable std::pmr::monotonic_buffer_resource arena_;
   std::unordered_set<std::unique_ptr<StructLike>, KeyHash, KeyEqual> set_;
 };