ci: enable sanitizer

Author: wgtmac

.github/workflows/sanitizer_test.yml

@@ -50,9 +50,9 @@ jobs:
       - name: Run Tests
         working-directory: build
         env:
-          ASAN_OPTIONS: log_path=out.log:detect_leaks=1:symbolize=1:strict_string_checks=1:halt_on_error=0:detect_container_overflow=0
+          ASAN_OPTIONS: log_path=out.log:detect_leaks=1:symbolize=1:strict_string_checks=1:halt_on_error=1:detect_container_overflow=0
           LSAN_OPTIONS: suppressions=${{ github.workspace }}/.github/lsan-suppressions.txt
-          UBSAN_OPTIONS: log_path=out.log:halt_on_error=0:print_stacktrace=1:suppressions=${{ github.workspace }}/.github/ubsan-suppressions.txt
+          UBSAN_OPTIONS: log_path=out.log:halt_on_error=1:print_stacktrace=1:suppressions=${{ github.workspace }}/.github/ubsan-suppressions.txt
         run: |
           ctest --output-on-failure
       - name: Save the test output

test/arrow_test.cc

@@ -100,6 +100,11 @@ TEST_P(ToArrowSchemaTest, PrimitiveType) {
   auto metadata = field->metadata();
   ASSERT_TRUE(metadata->Contains(kFieldIdKey));
   ASSERT_EQ(metadata->Get(kFieldIdKey), std::to_string(kFieldId));
+
+  // Release the arrow schema to avoid memory leak
+  if (arrow_schema.release != nullptr) {
+    arrow_schema.release(&arrow_schema);
+  }
 }
 
 INSTANTIATE_TEST_SUITE_P(
@@ -188,6 +193,11 @@ TEST(ToArrowSchemaTest, StructType) {
                                           kIntFieldId));
   ASSERT_NO_FATAL_FAILURE(CheckArrowField(*struct_field->field(1), ::arrow::Type::STRING,
                                           kStrFieldName, /*nullable=*/true, kStrFieldId));
+
+  // Release the arrow schema to avoid memory leak
+  if (arrow_schema.release != nullptr) {
+    arrow_schema.release(&arrow_schema);
+  }
 }
 
 TEST(ToArrowSchemaTest, ListType) {
@@ -216,6 +226,11 @@ TEST(ToArrowSchemaTest, ListType) {
   ASSERT_NO_FATAL_FAILURE(CheckArrowField(*list_field->value_field(),
                                           ::arrow::Type::INT64, kElemFieldName,
                                           /*nullable=*/true, kElemFieldId));
+
+  // Release the arrow schema to avoid memory leak
+  if (arrow_schema.release != nullptr) {
+    arrow_schema.release(&arrow_schema);
+  }
 }
 
 TEST(ToArrowSchemaTest, MapType) {
@@ -258,6 +273,11 @@ TEST(ToArrowSchemaTest, MapType) {
   ASSERT_NO_FATAL_FAILURE(CheckArrowField(*value_field, ::arrow::Type::INT32,
                                           kValueFieldName,
                                           /*nullable=*/true, kValueFieldId));
+
+  // Release the arrow schema to avoid memory leak
+  if (arrow_schema.release != nullptr) {
+    arrow_schema.release(&arrow_schema);
+  }
 }
 
 struct FromArrowSchemaParam {
@@ -293,6 +313,11 @@ TEST_P(FromArrowSchemaTest, PrimitiveType) {
   ASSERT_EQ(field.field_id(), kFieldId);
   ASSERT_EQ(field.optional(), param.optional);
   ASSERT_EQ(*field.type(), *param.iceberg_type);
+
+  // Release the exported schema to avoid memory leak
+  if (exported_schema.release != nullptr) {
+    exported_schema.release(&exported_schema);
+  }
 }
 
 INSTANTIATE_TEST_SUITE_P(
@@ -384,6 +409,11 @@ TEST(FromArrowSchemaTest, StructType) {
   ASSERT_EQ(str_iceberg_field.field_id(), kStrFieldId);
   ASSERT_TRUE(str_iceberg_field.optional());
   ASSERT_EQ(str_iceberg_field.type()->type_id(), TypeId::kString);
+
+  // Release the exported schema to avoid memory leak
+  if (exported_schema.release != nullptr) {
+    exported_schema.release(&exported_schema);
+  }
 }
 
 TEST(FromArrowSchemaTest, ListType) {
@@ -427,6 +457,11 @@ TEST(FromArrowSchemaTest, ListType) {
   ASSERT_EQ(element.field_id(), kElemFieldId);
   ASSERT_TRUE(element.optional());
   ASSERT_EQ(element.type()->type_id(), TypeId::kLong);
+
+  // Release the exported schema to avoid memory leak
+  if (exported_schema.release != nullptr) {
+    exported_schema.release(&exported_schema);
+  }
 }
 
 TEST(FromArrowSchemaTest, MapType) {
@@ -483,6 +518,11 @@ TEST(FromArrowSchemaTest, MapType) {
   ASSERT_EQ(value.field_id(), kValueFieldId);
   ASSERT_TRUE(value.optional());
   ASSERT_EQ(value.type()->type_id(), TypeId::kInt);
+
+  // Release the exported schema to avoid memory leak
+  if (exported_schema.release != nullptr) {
+    exported_schema.release(&exported_schema);
+  }
 }
 
 }  // namespace iceberg