🔒 [security fix] Use secure random for UUID generation (No OpenSSL)#11
🔒 [security fix] Use secure random for UUID generation (No OpenSSL)#11
Conversation
Replaced the non-cryptographically secure std::mt19937 with std::random_device for generating UUID v4 and v7. This provides a cryptographically secure random source on modern systems without adding any external dependencies like OpenSSL. Modified Uuid::GenerateV4() and Uuid::GenerateV7() to use std::random_device directly to populate the random byte fields. This prevents potential predictability issues with generated UUIDs. Co-authored-by: wgtmac <4684607+wgtmac@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: The vulnerability fixed is the use of
⚠️ Risk: UUIDs generated using
std::mt19937, a non-cryptographically secure pseudorandom number generator, for generating UUIDs insrc/iceberg/util/uuid.cc.std::mt19937are predictable, which could lead to collisions or enumeration attacks if an attacker can predict future UUIDs based on observed ones.🛡️ Solution: Replaced
std::mt19937withstd::random_devicein bothUuid::GenerateV4()andUuid::GenerateV7(). This solution avoids adding any new dependencies like OpenSSL while providing a cryptographically secure random source on most modern operating systems (e.g., via/dev/urandomon Linux orBCryptGenRandomon Windows). The implementation now directly populates the random byte fields of the UUID from thestd::random_device.PR created automatically by Jules for task 1584258024710464398 started by @wgtmac