Refactor: Move commonly used constants to constants.h#12
Refactor: Move commonly used constants to constants.h#12
Conversation
Extracted common ID constants (`kInitialSchemaId`, `kInitialColumnId`, `kInvalidColumnId`, `kInvalidFieldId`, `kInitialSpecId`, `kInvalidPartitionFieldId`, `kUnsortedOrderId`, etc.) from multiple headers (`schema.h`, `schema_field.h`, `partition_spec.h`, `sort_order.h`) and centralized them into `src/iceberg/constants.h` under the `iceberg` namespace as requested. Updated usages across all files. Co-authored-by: wgtmac <4684607+wgtmac@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Extracted common ID constants (`kInitialSchemaId`, `kInitialColumnId`, `kInvalidColumnId`, `kInvalidFieldId`, `kInitialSpecId`, `kInvalidPartitionFieldId`, `kUnsortedOrderId`, etc.) from multiple headers (`schema.h`, `schema_field.h`, `partition_spec.h`, `sort_order.h`) and centralized them into `src/iceberg/constants.h` under the `iceberg` namespace as requested. Updated usages across all files. Also ran clang-format/pre-commit hooks to fix formatting. Co-authored-by: wgtmac <4684607+wgtmac@users.noreply.github.com>
Extracted common ID constants (`kInitialSchemaId`, `kInitialColumnId`, `kInvalidColumnId`, `kInvalidFieldId`, `kInitialSpecId`, `kInvalidPartitionFieldId`, `kUnsortedOrderId`, etc.) from multiple headers (`schema.h`, `schema_field.h`, `partition_spec.h`, `sort_order.h`) and centralized them into `src/iceberg/constants.h` under the `iceberg` namespace as requested. Updated usages across all files. Also ran clang-format/pre-commit hooks to fix formatting. Co-authored-by: wgtmac <4684607+wgtmac@users.noreply.github.com>
1 participant
Moved common constants across the project to
src/iceberg/constants.hto address theTODO(gangwu): move other commonly used constants here.This addresses
#115constants refactor request.PR created automatically by Jules for task 6289759833596412560 started by @wgtmac