refactor(orc): inline validity bitmap appends

Author: wgtmac

src/paimon/format/orc/orc_adapter.cpp

@@ -101,14 +101,6 @@ class OrcBackedArrowBuffer : public arrow::ResizableBuffer {
     ::orc::DataBuffer<T> orc_buffer_;
 };
 
-template <typename AppendToBitmap>
-arrow::Status AppendValidBytesToBitmap(arrow::ArrayBuilder* builder, int64_t length,
-                                       AppendToBitmap append_to_bitmap) {
-    ARROW_RETURN_NOT_OK(builder->Reserve(length));
-    append_to_bitmap();
-    return arrow::Status::OK();
-}
-
 class EmptyBuilder : public arrow::ArrayBuilder {
  public:
     using arrow::ArrayBuilder::SetNotNull;
@@ -152,9 +144,9 @@ class UnPooledBooleanBuilder : public EmptyBuilder {
     }
 
     arrow::Status SetNulls(const uint8_t* valid_bytes, int64_t length) {
-        return AppendValidBytesToBitmap(this, length, [this, valid_bytes, length] {
-            this->UnsafeAppendToBitmap(valid_bytes, length);
-        });
+        ARROW_RETURN_NOT_OK(this->Reserve(length));
+        this->UnsafeAppendToBitmap(valid_bytes, length);
+        return arrow::Status::OK();
     }
 
     arrow::Status SetData(const uint8_t* data, int64_t length) {
@@ -199,9 +191,9 @@ class UnPooledPrimitiveBuilder : public arrow::NumericBuilder<Type> {
     }
 
     arrow::Status SetNulls(const uint8_t* valid_bytes, int64_t length) {
-        return AppendValidBytesToBitmap(this, length, [this, valid_bytes, length] {
-            this->UnsafeAppendToBitmap(valid_bytes, length);
-        });
+        ARROW_RETURN_NOT_OK(this->Reserve(length));
+        this->UnsafeAppendToBitmap(valid_bytes, length);
+        return arrow::Status::OK();
     }
 
     arrow::Status FinishInternal(std::shared_ptr<arrow::ArrayData>* out) override {
@@ -242,9 +234,9 @@ class UnPooledLargeBinaryBuilder : public arrow::LargeBinaryBuilder {
         length_ += length;
     }
     arrow::Status SetNulls(const uint8_t* valid_bytes, int64_t length) {
-        return AppendValidBytesToBitmap(this, length, [this, valid_bytes, length] {
-            this->UnsafeAppendToBitmap(valid_bytes, length);
-        });
+        ARROW_RETURN_NOT_OK(this->Reserve(length));
+        this->UnsafeAppendToBitmap(valid_bytes, length);
+        return arrow::Status::OK();
     }
     arrow::Status FinishInternal(std::shared_ptr<arrow::ArrayData>* out) override {
         std::shared_ptr<arrow::Buffer> null_bitmap;
@@ -289,9 +281,9 @@ class UnPooledBinaryBuilder : public arrow::BinaryBuilder {
     }
 
     arrow::Status SetNulls(const uint8_t* valid_bytes, int64_t length) {
-        return AppendValidBytesToBitmap(this, length, [this, valid_bytes, length] {
-            this->UnsafeAppendToBitmap(valid_bytes, length);
-        });
+        ARROW_RETURN_NOT_OK(this->Reserve(length));
+        this->UnsafeAppendToBitmap(valid_bytes, length);
+        return arrow::Status::OK();
     }
 
     arrow::Status FinishInternal(std::shared_ptr<arrow::ArrayData>* out) override {
@@ -331,9 +323,9 @@ class UnPooledListBuilder : public EmptyBuilder {
     }
 
     arrow::Status SetNulls(const uint8_t* valid_bytes, int64_t length) {
-        return AppendValidBytesToBitmap(this, length, [this, valid_bytes, length] {
-            this->UnsafeAppendToBitmap(valid_bytes, length);
-        });
+        ARROW_RETURN_NOT_OK(this->Reserve(length));
+        this->UnsafeAppendToBitmap(valid_bytes, length);
+        return arrow::Status::OK();
     }
 
     void SetOffsets(const std::shared_ptr<arrow::Buffer>& offsets) {
@@ -381,9 +373,9 @@ class UnPooledStructBuilder : public EmptyBuilder {
     }
 
     arrow::Status SetNulls(const uint8_t* valid_bytes, int64_t length) {
-        return AppendValidBytesToBitmap(this, length, [this, valid_bytes, length] {
-            this->UnsafeAppendToBitmap(valid_bytes, length);
-        });
+        ARROW_RETURN_NOT_OK(this->Reserve(length));
+        this->UnsafeAppendToBitmap(valid_bytes, length);
+        return arrow::Status::OK();
     }
 
     arrow::Status FinishInternal(std::shared_ptr<arrow::ArrayData>* out) override {
@@ -509,9 +501,9 @@ class UnPooledStringDictionaryBuilder : public EmptyBuilder {
         indices_ = indices;
     }
     arrow::Status SetNulls(const uint8_t* valid_bytes, int64_t length) {
-        return AppendValidBytesToBitmap(this, length, [this, valid_bytes, length] {
-            this->UnsafeAppendToBitmap(valid_bytes, length);
-        });
+        ARROW_RETURN_NOT_OK(this->Reserve(length));
+        this->UnsafeAppendToBitmap(valid_bytes, length);
+        return arrow::Status::OK();
     }
     arrow::Status FinishInternal(std::shared_ptr<arrow::ArrayData>* out) override {
         std::shared_ptr<arrow::Buffer> null_bitmap;