refactor(orc): preserve builder reserve dispatch

Author: wgtmac

src/paimon/format/orc/orc_adapter.cpp

@@ -101,24 +101,11 @@ class OrcBackedArrowBuffer : public arrow::ResizableBuffer {
     ::orc::DataBuffer<T> orc_buffer_;
 };
 
-arrow::Status AppendValidBytesToBitmap(arrow::ArrayBuilder* builder,
-                                       arrow::TypedBufferBuilder<bool>* null_bitmap_builder,
-                                       int64_t* length, int64_t* null_count,
-                                       const uint8_t* valid_bytes, int64_t valid_length) {
-    int64_t min_capacity = builder->length() + valid_length;
-    if (min_capacity > builder->capacity()) {
-        int64_t new_capacity =
-            arrow::BufferBuilder::GrowByFactor(builder->capacity(), min_capacity);
-        ARROW_RETURN_NOT_OK(builder->arrow::ArrayBuilder::Resize(new_capacity));
-    }
-
-    if (valid_bytes == nullptr) {
-        null_bitmap_builder->UnsafeAppend(valid_length, true);
-    } else {
-        null_bitmap_builder->UnsafeAppend(valid_bytes, valid_length);
-        *null_count = null_bitmap_builder->false_count();
-    }
-    *length += valid_length;
+template <typename AppendToBitmap>
+arrow::Status AppendValidBytesToBitmap(arrow::ArrayBuilder* builder, int64_t length,
+                                       AppendToBitmap append_to_bitmap) {
+    ARROW_RETURN_NOT_OK(builder->Reserve(length));
+    append_to_bitmap();
     return arrow::Status::OK();
 }
 
@@ -165,8 +152,9 @@ class UnPooledBooleanBuilder : public EmptyBuilder {
     }
 
     arrow::Status SetNulls(const uint8_t* valid_bytes, int64_t length) {
-        return AppendValidBytesToBitmap(this, &null_bitmap_builder_, &length_, &null_count_,
-                                        valid_bytes, length);
+        return AppendValidBytesToBitmap(this, length, [this, valid_bytes, length] {
+            this->UnsafeAppendToBitmap(valid_bytes, length);
+        });
     }
 
     arrow::Status SetData(const uint8_t* data, int64_t length) {
@@ -211,8 +199,9 @@ class UnPooledPrimitiveBuilder : public arrow::NumericBuilder<Type> {
     }
 
     arrow::Status SetNulls(const uint8_t* valid_bytes, int64_t length) {
-        return AppendValidBytesToBitmap(this, &this->null_bitmap_builder_, &this->length_,
-                                        &this->null_count_, valid_bytes, length);
+        return AppendValidBytesToBitmap(this, length, [this, valid_bytes, length] {
+            this->UnsafeAppendToBitmap(valid_bytes, length);
+        });
     }
 
     arrow::Status FinishInternal(std::shared_ptr<arrow::ArrayData>* out) override {
@@ -253,8 +242,9 @@ class UnPooledLargeBinaryBuilder : public arrow::LargeBinaryBuilder {
         length_ += length;
     }
     arrow::Status SetNulls(const uint8_t* valid_bytes, int64_t length) {
-        return AppendValidBytesToBitmap(this, &null_bitmap_builder_, &length_, &null_count_,
-                                        valid_bytes, length);
+        return AppendValidBytesToBitmap(this, length, [this, valid_bytes, length] {
+            this->UnsafeAppendToBitmap(valid_bytes, length);
+        });
     }
     arrow::Status FinishInternal(std::shared_ptr<arrow::ArrayData>* out) override {
         std::shared_ptr<arrow::Buffer> null_bitmap;
@@ -299,8 +289,9 @@ class UnPooledBinaryBuilder : public arrow::BinaryBuilder {
     }
 
     arrow::Status SetNulls(const uint8_t* valid_bytes, int64_t length) {
-        return AppendValidBytesToBitmap(this, &null_bitmap_builder_, &length_, &null_count_,
-                                        valid_bytes, length);
+        return AppendValidBytesToBitmap(this, length, [this, valid_bytes, length] {
+            this->UnsafeAppendToBitmap(valid_bytes, length);
+        });
     }
 
     arrow::Status FinishInternal(std::shared_ptr<arrow::ArrayData>* out) override {
@@ -340,8 +331,9 @@ class UnPooledListBuilder : public EmptyBuilder {
     }
 
     arrow::Status SetNulls(const uint8_t* valid_bytes, int64_t length) {
-        return AppendValidBytesToBitmap(this, &null_bitmap_builder_, &length_, &null_count_,
-                                        valid_bytes, length);
+        return AppendValidBytesToBitmap(this, length, [this, valid_bytes, length] {
+            this->UnsafeAppendToBitmap(valid_bytes, length);
+        });
     }
 
     void SetOffsets(const std::shared_ptr<arrow::Buffer>& offsets) {
@@ -389,8 +381,9 @@ class UnPooledStructBuilder : public EmptyBuilder {
     }
 
     arrow::Status SetNulls(const uint8_t* valid_bytes, int64_t length) {
-        return AppendValidBytesToBitmap(this, &null_bitmap_builder_, &length_, &null_count_,
-                                        valid_bytes, length);
+        return AppendValidBytesToBitmap(this, length, [this, valid_bytes, length] {
+            this->UnsafeAppendToBitmap(valid_bytes, length);
+        });
     }
 
     arrow::Status FinishInternal(std::shared_ptr<arrow::ArrayData>* out) override {
@@ -516,8 +509,9 @@ class UnPooledStringDictionaryBuilder : public EmptyBuilder {
         indices_ = indices;
     }
     arrow::Status SetNulls(const uint8_t* valid_bytes, int64_t length) {
-        return AppendValidBytesToBitmap(this, &null_bitmap_builder_, &length_, &null_count_,
-                                        valid_bytes, length);
+        return AppendValidBytesToBitmap(this, length, [this, valid_bytes, length] {
+            this->UnsafeAppendToBitmap(valid_bytes, length);
+        });
     }
     arrow::Status FinishInternal(std::shared_ptr<arrow::ArrayData>* out) override {
         std::shared_ptr<arrow::Buffer> null_bitmap;