This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Conversation
amin-nejad
suggested changes
Dec 12, 2022
Contributor
amin-nejad
left a comment
amin-nejad
left a comment
There was a problem hiding this comment.
Just a small change requested. Another thing is that the ticket number is wrong - it doesn't matter now but please ensure this is correct going forward
Comment on lines
+29
to
+31
| body.weWant.issuer === "bitstamp" | ||
| ? BitStampIssuers[body.weWant.currency] | ||
| : GateHubIssuers[body.weWant.currency]; |
Contributor
There was a problem hiding this comment.
I don't think we should be defaulting to "gatehub" if the provided issuer is not "bitstamp". Anything that can lead to unexpected behaviour should be avoided I think. We should just enforce that the issuer needs to be provided so they have to explicitly provide either "gatehub" or "bitstamp"
Contributor
There was a problem hiding this comment.
This also means the python script needs to be updated to add the issuer to the API call that is made
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.