Skip to content

Commit 5747a56

Browse files
committed
build shared extensions before frankenphp
1 parent d52ba59 commit 5747a56

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

src/Package/Target/php.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,6 @@ public function postInstall(TargetPackage $package, PackageInstaller $installer)
368368
return;
369369
}
370370
if (SystemTarget::isUnix()) {
371-
$package->runStage([$this, 'unixBuildSharedExt']);
372371
if ($installer->interactive) {
373372
InteractiveTerm::indicateProgress('Running PHP smoke tests');
374373
}

src/Package/Target/php/unix.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -552,8 +552,10 @@ public function build(TargetPackage $package, PackageInstaller $installer): void
552552
$package->runStage([$this, 'configureForUnix']);
553553
$package->runStage([$this, 'makeForUnix']);
554554
}
555-
// shared extensions build in php's postInstall (php.php) so they run AFTER
556-
// frankenphp's main-loop build — frankenphp links libphp only, not the .so exts.
555+
556+
// shared extensions build before frankenphp so their undefined references are
557+
// collected into libphp's exported dynamic-symbol list.
558+
$package->runStage([$this, 'unixBuildSharedExt']);
557559
}
558560

559561
/**

0 commit comments

Comments
 (0)