Add center sideview positions#62
Open
borjafac wants to merge 3 commits into
Open
Conversation
Introduce four new SideviewPosition variants (center_left, center_top, center_right, center_bottom) and add them to SideviewPositions and SideviewPositionDescriptions to support additional sideview alignment options.
wheaney
requested changes
May 27, 2026
wheaney
left a comment
wheaney
left a comment
Owner
There was a problem hiding this comment.
Same as comments in Sombrero:
Let's use "center" for horizontal/x axis, and "middle" for vertical/y axis. Also follow the naming scheme we already had here: - e.g. "middle-left" and "top-center"; similarly, 4 should be updated to be "middle-center" for consistency.
wheaney
reviewed
May 27, 2026
Replace the SideviewPosition identifiers 'center', 'center_left' and 'center_right' with 'middle_center', 'middle_left' and 'middle_right'. Updated the SideviewPosition type, SideviewPositions array and SideviewPositionDescriptions (including the display label change from "Center" to "Middle Center") to reflect the new keys.
Author
|
Changes done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce four new SideviewPosition variants (center_left, center_top, center_right, center_bottom) and add them to SideviewPositions and SideviewPositionDescriptions to support additional sideview alignment options.