Update variant model tests for labels

Signed-off-by: Michał Górny <mgorny@quansight.com>

Author: mgorny

tests/models/test_variant.py

@@ -6,9 +6,11 @@
 import pytest
 from hypothesis import given
 from hypothesis import strategies as st
+from variantlib.constants import NULL_VARIANT_LABEL
 from variantlib.constants import VALIDATION_FEATURE_NAME_REGEX
 from variantlib.constants import VALIDATION_NAMESPACE_REGEX
 from variantlib.constants import VALIDATION_VALUE_REGEX
+from variantlib.constants import VALIDATION_VARIANT_LABEL_REGEX
 from variantlib.errors import ValidationError
 from variantlib.models.variant import VARIANT_HASH_LENGTH
 from variantlib.models.variant import VariantDescription
@@ -214,6 +216,7 @@ def test_null_variant() -> None:
     vdesc = VariantDescription()
     assert vdesc.properties == []
     assert vdesc.hexdigest == hashlib.sha256(b"").hexdigest()[:VARIANT_HASH_LENGTH]
+    assert vdesc.label == NULL_VARIANT_LABEL
 
 
 def test_variantdescription_initialization() -> None:
@@ -224,7 +227,8 @@ def test_variantdescription_initialization() -> None:
     vprop2 = VariantProperty(
         namespace="tyrell_corporation", feature="client_id", value="secret_pass"
     )
-    vdesc = VariantDescription([vprop1, vprop2])
+    vdesc = VariantDescription([vprop1, vprop2], label="test")
+    assert vdesc.label == "test"
 
     # Check that the _data property is a list
     assert isinstance(vdesc.properties, list)
@@ -257,14 +261,13 @@ def test_variantdescription_duplicate_data() -> None:
 
 
 def test_variantdescription_partial_duplicate_data() -> None:
-    # Test that duplicate VariantProperty instances are removed
     vprop1 = VariantProperty(
         namespace="omnicorp", feature="custom_feat", value="secret_value"
     )
     vprop2 = VariantProperty(
         namespace="omnicorp", feature="custom_feat", value="another_value"
     )
-    VariantDescription([vprop1, vprop2])
+    VariantDescription([vprop1, vprop2], label="test")
 
 
 def test_variantdescription_sorted_data() -> None:
@@ -278,7 +281,7 @@ def test_variantdescription_sorted_data() -> None:
     vprop3 = VariantProperty(
         namespace="omnicorp", feature="secret_pass", value="client_value"
     )
-    vdesc = VariantDescription([vprop1, vprop2, vprop3])
+    vdesc = VariantDescription([vprop1, vprop2, vprop3], label="test")
 
     # Check that data is sorted by namespace, feature, and value
     sorted_vprops = sorted(
@@ -296,7 +299,7 @@ def test_variantdescription_hexdigest() -> None:
         namespace="tyrell_corporation", feature="client_id", value="secret_pass"
     )
     vprops = [vprop1, vprop2]
-    vdesc = VariantDescription(vprops)
+    vdesc = VariantDescription(vprops, label="test")
 
     # Compute the expected hash using shake_128 (mock the hash output for testing)
     hash_object = hashlib.sha256(
@@ -314,13 +317,15 @@ def test_variantdescription_hexdigest_adjacent_strings() -> None:
             [
                 VariantProperty("a", "b", "cx"),
                 VariantProperty("d", "e", "f"),
-            ]
+            ],
+            label="test",
         ).hexdigest
         != VariantDescription(
             [
                 VariantProperty("a", "b", "c"),
                 VariantProperty("xd", "e", "f"),
-            ]
+            ],
+            label="another",
         ).hexdigest
     )
 
@@ -390,7 +395,7 @@ def test_fuzzy_variantprop(namespace: str, feature: str, value: str) -> None:
 )
 def test_fuzzy_variantdescription(vprop: list[VariantProperty]) -> None:
     # Fuzzy test for random combinations of VariantDescription
-    vdesc = VariantDescription(vprop)
+    vdesc = VariantDescription(vprop, label="test")
     assert isinstance(vdesc.properties, list)
     assert len(vdesc.properties) >= 1
 
@@ -414,8 +419,23 @@ def test_fuzzy_variantdescription(vprop: list[VariantProperty]) -> None:
                 value=st.from_regex(VALIDATION_NAMESPACE_REGEX, fullmatch=True),
             ),
         ),
+        label=st.from_regex(VALIDATION_VARIANT_LABEL_REGEX, fullmatch=True),
     )
 )
 def test_random_hexdigest(vdesc: VariantDescription) -> None:
     assert isinstance(vdesc.hexdigest, str)
     assert len(vdesc.hexdigest) == VARIANT_HASH_LENGTH
+
+
+@pytest.mark.xfail(reason="Validation is disabled for porting")
+def test_null_variant_label():
+    with pytest.raises(
+        ValidationError,
+        match=rf"{NULL_VARIANT_LABEL!r} label can be used only for the null variant",
+    ):
+        VariantDescription([VariantProperty("a", "b", "c")], label=NULL_VARIANT_LABEL)
+    with pytest.raises(
+        ValidationError,
+        match=rf"Null variant must always use {NULL_VARIANT_LABEL!r} label",
+    ):
+        VariantDescription(label="zuul")