Remove dynamic plugin support#113
Merged
Merged
Conversation
Block dynamic plugins, remove relevant tests. No API changes yet. Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Now that we don't allow dynamic plugins anymore, there is no reason to allow full version specifier syntax. We still allow `.` for versions themselves, though. Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
We've broken the API anyway. Signed-off-by: Michał Górny <mgorny@quansight.com>
mgorny
changed the title
Collaborator
Author
|
Okay, all done. The API is back to where it was at the beginning. I still need to update CLI commands but let's do that separately. Now I need working plugins again. |
Member
|
Sorry got busy - will review tomorrow |
Signed-off-by: Michał Górny <mgorny@quansight.com>
There is only one command remaining, so no point in splitting it. Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
DEKHTIARJonathan
approved these changes
Sep 5, 2025
Member
DEKHTIARJonathan
left a comment
DEKHTIARJonathan
left a comment
There was a problem hiding this comment.
499 lines removed
295 added !
That's what's up !
Two tiny remarks - feel free to adjust or drop. You can merge
Signed-off-by: Michał Górny <mgorny@quansight.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the bits used for dynamic plugin support, and restrict values to disallow version operators.
This is the "non-breaking" part of the change: it blocks dynamic plugins, but static plugin API remain unchanged for now.