Skip to content

Use hierarchical output for plugins get-configs #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgorny wants to merge 1 commit into from
Closed

Use hierarchical output for plugins get-configs #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 56 additions & 30 deletions tests/commands/test_plugins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,20 +31,30 @@ def test_plugins_get_all_configs(
assert (
capsys.readouterr().out
== """\
test_namespace :: name1 :: val1a
test_namespace :: name1 :: val1b
test_namespace :: name1 :: val1c
test_namespace :: name1 :: val1d
test_namespace :: name2 :: val2a
test_namespace :: name2 :: val2b
test_namespace :: name2 :: val2c
second_namespace :: name3 :: val3a
second_namespace :: name3 :: val3b
second_namespace :: name3 :: val3c
incompatible_namespace :: flag1 :: on
incompatible_namespace :: flag2 :: on
incompatible_namespace :: flag3 :: on
incompatible_namespace :: flag4 :: on
test_namespace:
name1: (single-value)
val1a
val1b
val1c
val1d
name2: (single-value)
val2a
val2b
val2c
second_namespace:
name3: (single-value)
val3a
val3b
val3c
incompatible_namespace:
flag1: (single-value)
on
flag2: (single-value)
on
flag3: (single-value)
on
flag4: (single-value)
on
"""
)

Expand All @@ -57,9 +67,11 @@ def test_plugins_get_all_configs_filter_namespace(
assert (
capsys.readouterr().out
== """\
second_namespace :: name3 :: val3a
second_namespace :: name3 :: val3b
second_namespace :: name3 :: val3c
second_namespace:
name3: (single-value)
val3a
val3b
val3c
"""
)

Expand All @@ -72,10 +84,14 @@ def test_plugins_get_all_configs_filter_feature(
assert (
capsys.readouterr().out
== """\
test_namespace :: name1 :: val1a
test_namespace :: name1 :: val1b
test_namespace :: name1 :: val1c
test_namespace :: name1 :: val1d
test_namespace:
name1: (single-value)
val1a
val1b
val1c
val1d
second_namespace:
incompatible_namespace:
"""
)

Expand All @@ -88,12 +104,17 @@ def test_plugins_get_supported_configs(
assert (
capsys.readouterr().out
== """\
test_namespace :: name1 :: val1a
test_namespace :: name1 :: val1b
test_namespace :: name2 :: val2a
test_namespace :: name2 :: val2b
test_namespace :: name2 :: val2c
second_namespace :: name3 :: val3a
test_namespace:
name1: (single-value)
val1a
val1b
name2: (single-value)
val2a
val2b
val2c
second_namespace:
name3: (single-value)
val3a
"""
)

Expand All @@ -106,7 +127,9 @@ def test_plugins_get_supported_configs_filter_namespace(
assert (
capsys.readouterr().out
== """\
second_namespace :: name3 :: val3a
second_namespace:
name3: (single-value)
val3a
"""
)

Expand All @@ -119,7 +142,10 @@ def test_plugins_get_supported_configs_filter_feature(
assert (
capsys.readouterr().out
== """\
test_namespace :: name1 :: val1a
test_namespace :: name1 :: val1b
test_namespace:
name1: (single-value)
val1a
val1b
second_namespace:
"""
)
7 changes: 4 additions & 3 deletions variantlib/commands/plugins/get_configs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from typing import TYPE_CHECKING

from variantlib import __package_name__
from variantlib.models.variant import VariantProperty

if TYPE_CHECKING:
from variantlib.plugins.loader import BasePluginLoader
Expand Down Expand Up @@ -46,10 +45,12 @@ def get_configs(args: list[str], plugin_loader: BasePluginLoader) -> None:
if parsed_args.namespace not in (provider_cfg.namespace, None):
continue

sys.stdout.write(f"{provider_cfg.namespace}:\n")
for feature in provider_cfg.configs:
if parsed_args.feature not in (feature.name, None):
continue

mv = "multi-value" if feature.multi_value else "single-value"
sys.stdout.write(f" {feature.name}: ({mv})\n")
for value in feature.values:
vprop = VariantProperty(provider_cfg.namespace, feature.name, value)
sys.stdout.write(f"{vprop.to_str()}\n")
sys.stdout.write(f" {value}\n")
Loading