Some fixes for AoT plugins#124
Merged
Merged
Conversation
DEKHTIARJonathan
approved these changes
Oct 13, 2025
Member
|
LGTM - Fix conflict & merge |
Use `multi_value=False` rather than `True` for AoT properties. As Jonathan pointed out, multi-value properties only make sense for filtering, given that the system may support only a subset of all properties. However, AoT properties are always supported, so there is no real difference between a wheel built with multiple values for a given property, and one built with just the highest value. Signed-off-by: Michał Górny <mgorny@quansight.com>
Use a dedicated AoT plugin rather than piggy-backing on a regular plugin, where independent changes can trigger test failures. Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
mgorny
force-pushed
the
multi-value-fixes
branch
from
d253623 to
1347dcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multi_value=Falsefor AoT properties.multi_value=True.This doesn't switch to the new API yet, but I've started saying "AoT plugins" where I've changed stuff.