fix(view): drop /wheels/* top nav in favor of debug footer (#2419)

bpamiri · web-flow · commit ef70e59c9bf9 · 2026-05-04T17:20:32.000-07:00
The top navigation in _header.cfm duplicated links already provided by the debug bar emitted at onrequestend (System Info / Routes / API / Guides / Migrator / Packages / Plugins). Drop the nav include to eliminate the duplicate surface. Public.cfc handlers <cfinclude> their views directly without going through renderView, so request.wheels.showDebugInformation never flipped on /wheels/info, /wheels/routes, etc. — the bar wouldn't have appeared even after dropping the top nav. Opt into the bar from both _header.cfm and _header_simple.cfm so any view using either layout self-arms the debug footer. Extends the pattern from #2406 (welcome + error pages) to the rest of the dev-tools admin pages.
diff --git a/vendor/wheels/public/layout/_header.cfm b/vendor/wheels/public/layout/_header.cfm
@@ -7,6 +7,17 @@ if (!IsDefined("pageHeader")) {
 // Css Path
 request.wheelsInternalAssetPath = application.wheels.webpath & "wheels/public/assets";
 
+// Opt the request into the dev debug bar emitted at onrequestend.
+// Public.cfc handlers <cfinclude> these views directly (bypassing
+// renderView, which is what normally flips this flag), so without this
+// the bar wouldn't appear on /wheels/info, /wheels/routes, etc. — which
+// is exactly where developers expect dev-tools nav. Setting it during
+// view rendering (here) instead of in the controller preamble avoids
+// touching request scope before the framework is fully wired.
+if (StructKeyExists(request, "wheels") && IsStruct(request.wheels)) {
+	request.wheels.showDebugInformation = true;
+}
+
 // Primary Navigation
 request.navigation = [
 	{
@@ -440,12 +451,10 @@ if (StructKeyExists(url, "refresh")) {
 	<body>
 	<cfif request.isFluid>
 		<div id="main" class="ui grid stackable h-100">
-		<cfinclude template="_navigation.cfm">
 		<div id="top" class="sixteen wide stretched column ">
 		<div class="ui grid stackable">
 	<cfelse>
 		<div id="main">
-		<cfinclude template="_navigation.cfm">
 		<div id="top" class="margin-top">
 	</cfif>
 	<!--- cfformat-ignore-end --->
diff --git a/vendor/wheels/public/layout/_header_simple.cfm b/vendor/wheels/public/layout/_header_simple.cfm
@@ -1,6 +1,16 @@
 <!---
 Static simple version of the header/navigation for output on error screens
 --->
+<cfscript>
+// Opt the request into the dev debug bar emitted at onrequestend.
+// Public.cfc::index() <cfinclude>s congratulations.cfm directly (bypassing
+// renderView, which is what normally flips this flag), so without this
+// the bar wouldn't appear on the welcome page when served from the
+// framework's Public dispatcher. Same opt-in pattern as _header.cfm.
+if (StructKeyExists(request, "wheels") && IsStruct(request.wheels)) {
+	request.wheels.showDebugInformation = true;
+}
+</cfscript>
 <cfoutput>
 <!--- cfformat-ignore-start --->
 <!DOCTYPE html>
