docs(changelog): correct drifted PR refs and fill 4.0.2 gaps#2816
Conversation
…leased] Entries in [Unreleased] cited issue numbers (or earlier stacked-PR numbers) rather than their merge-PR numbers, and six entries carried no reference at all. Correct 18 references to the actual merge PRs and add the five missing user-facing entries: #2814 (native apt/yum repos), #2804 (Migration.cfc command alias sweep), #2813 (skip spurious commit after rollback in migrateIndividual), and #2777 / #2801 (Linux install URL and migrator-table doc fixes). No existing prose changed beyond the trailing reference, and nothing was misfiled in the 4.0.1 section (verified by grep). Internal-only CI/chore/blog PRs (#2797, #2772, #2771, #2770) and the user-invisible bucket rename (#2788) are intentionally omitted. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com>
There was a problem hiding this comment.
Wheels Bot — Reviewer A
TL;DR: Pure CHANGELOG.md hygiene -- 18 reference corrections (issue/stacked-PR numbers to actual merge-PR numbers) plus 5 missing user-facing entries for the 4.0.2 changeset. Every reference spot-checked against its merged PR title; all verified. Approving.
Docs
Spot-checked all 23 modified or added references against GitHub:
| Entry | Old ref | New ref | Verified title |
|---|---|---|---|
| t.primaryKey() aliases | #2803 | #2812 | feat(migrator): t.primaryKey() columnName/columnNames aliases |
| t.references() aliases | #2781 | #2802 | feat(migrator): t.references() columnNames alias + underscore flag |
| Migration.cfc command sweep | (none) | #2804 | feat(migrator): Migration.cfc command consistency sweep |
| Advisory upgrade-check scaffolding | (none) | #2805 | refactor(cli): add advisory tier to wheels upgrade check scanner |
| Upgrade-check advisory checks | (none) | #2807 | feat(cli): underscore-references opt-in advisories in wheels upgrade check |
| wheels_migrator_versions columns | #2780 | #2800 | feat(migrator): enrich wheels_migrator_versions with name + applied_at |
| model() inside migration tx fix | #2789 | #2810 | fix(model): bypass nested cftransaction when migrator owns the outer |
| migrateIndividual spurious commit | (none) | #2813 | fix(migrator): skip transaction commit after rollback in migrateIndividual() |
| Upgrade-check config scan fix | #2808 | #2809 | fix(cli): wheels upgrade underscore-flag pre-check scans all of config/ |
| migrate latest orphan fix | #2780 | #2798 | fix(migrator): handle orphan versions in shared dev databases |
| Namespace route rejection | #2791 | #2794 | fix(mapper): reject redundant namespace prefix in to= and controller= |
| WheelsTest auto-bind globals | #2790 | #2793 | fix(test): auto-bind include-injected globals into WheelsTest spec scope |
| SELECT clause quoting | (none) | #2787 | fix(model): quote column identifiers in SELECT clause builder |
| packages install alias | (none) | #2786 | fix(cli): make wheels packages install a real alias for add in dispatch |
| BrowserTest NotWired error | (none) | #2782 | fix(test): BrowserTest reports unwired this.browser with browserDescribe() hint |
| BrowserTest base URL | #2779 | #2783 | fix(test): resolve BrowserTest base URL through layered lookup at instance time |
| Linux package nesting | #2773 | #2776 | fix(ci): stop double-nesting framework inside Linux .deb/.rpm packages |
| onError guard | (none) | #2774 | fix(cli): guard application.wo in onError so init failures don't cascade |
| ?reload=true global change | #2792 | #2795 | fix(events): re-include app/global/*.cfm on bare ?reload=true when files change |
| Native apt/yum repos | (none) | #2814 | feat(distribution): land Phase 2 native apt/yum repos via Cloudflare R2 |
| Linux install-URL fix | (none) | #2777 | docs(web/guides): correct Linux bleeding-edge install URLs to wheels-be_* |
| schema_migrations rename | (none) | #2801 | docs: propagate schema_migrations to wheels_migrator_versions rename to sibling v4 docs |
The unchanged test-local.sh entry (#2796) and the intentional omissions (#2797, #2772, #2771, #2770 CI/chore/blog; #2788 bucket rename subsumed by #2814) all check out.
Commits
Single commit docs(changelog): correct drifted PR refs and fill 4.0.2 gaps in [Unreleased] -- valid docs type, 77-char subject within the 100-char limit, not ALL-CAPS, body explains the why, DCO Signed-off-by trailer present.
Wheels Bot — Reviewer B (round 1)A's review is substantive and the approval verdict is correct. One minor incompleteness in the spot-check table, but it does not affect the correctness of the underlying change. SycophancyNone detected. A backed the approval with a 22-row reference-verification table and explicit commit-message checks — not a bare "LGTM." False positivesNone detected. Every row I cross-checked against the diff matched: old ref, new ref, and entry prose all align. Missed issuesOne gap: A claims "Spot-checked all 23 modified or added references" but the table contains 22 entries. The missing row is the Three new Verdict alignmentApprove is the right call for a documentation-only PR with no code, migration, or security surface. ConvergenceAligned. The missing table row is a bookkeeping omission; the actual change is correct and the approval is warranted. Joint recommendation: approve and merge. |
|
No code change needed — Reviewer B's flagged gap is in Reviewer A's verification table (22 rows vs the 23 claimed), not in the diff. The |
Summary
The
[Unreleased]section already held most of the 4.0.2 changeset, but its PR references had drifted: entries cited the issue number (filed first, lower) or an earlier stacked-PR number instead of the actual merge-PR number, and six entries had no reference at all. This corrects the section so every entry ends with its real merge PR.#2803→#2812,#2781→#2802,#2789→#2810,#2780→#2798/#2799/#2800,#2808→#2809,#2791→#2794,#2790→#2793,#2779→#2783,#2773→#2776,#2792→#2795; and 6 ref-less entries now carry#2807/#2805/#2787/#2786/#2782/#2774.#2814(native apt/yum repos),#2804(Migration.cfc command alias sweep),#2813(skip spurious commit after rollback inmigrateIndividual),#2777+#2801(Linux install-URL & migrator-table doc fixes).#2797#2772#2771#2770(CI/chore/blog) and#2788(internal bucket-repo rename, subsumed by#2814).Verified by grep that nothing belonging to 4.0.2 was misfiled in the
# [4.0.1]block, so no entries were moved. Existing entry prose is unchanged except for the trailing reference; the 5 new entries were written from verified commit bodies. Terminal punctuation follows the file's dominant convention —(#NNNN)with no trailing period (167 vs 12 across the file).Test plan
docs(changelog):headersites/guidesbuild unaffected (Markdown-only change)🤖 Generated with Claude Code