Fix N San Jose neighbourhood record#133
Open
stepps00 wants to merge 1 commit into
Open
Conversation
nvkelso
reviewed
Aug 16, 2022
| "mz:hierarchy_label":1, | ||
| "mz:is_current":-1, | ||
| "mz:hierarchy_label":0, | ||
| "mz:is_current":1, |
Contributor
There was a problem hiding this comment.
Should it not be current if we're cessating and superseding it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes whosonfirst-data/whosonfirst-data#1994
WOF has two records for "North San Jose" - this macrohood and this neighbourhood.
Both records were updated as part of whosonfirst-data/whosonfirst-data#424. The macrohood was created as a new record, and the neighbourhood was clipped to the San Jose locality polygon. Another step should have been added, to supersede the neighbourhood into the new macrohood record, but that work wasn't done.
This PR supersedes the neighbourhood into the macrhood record. I also noticed some name discrepancies in the macrohood record, so I've cleaned those up, too. No PIP work needed, can merge once approved.