Skip to content

Fixing setup of resource name when loading i18n resources #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xomit wants to merge 3 commits into
base: master
Choose a base branch
from
+5 −9
Open

Fixing setup of resource name when loading i18n resources #1467

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc1cccb
fix: fixing of loading of i18n resources
May 26, 2026
100f2cd
Merge branch 'wicketstuff:master' into master
xomit May 27, 2026
10b0981
fix: fixing setup of resource name when loading i18n resources
May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions ...arent/select2/src/main/java/org/wicketstuff/select2/Select2LanguageResourceReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import de.agilecoders.wicket.webjars.request.resource.WebjarsJavaScriptResourceReference;

import static org.apache.wicket.util.string.Strings.isEmpty;
import org.apache.wicket.request.resource.JavaScriptResourceReference;

/**
Expand All @@ -12,7 +13,6 @@
*/
class Select2LanguageResourceReference extends WebjarsJavaScriptResourceReference {
private static final long serialVersionUID = 1L;
//private static final String resourceName = "res/js/i18n/%s.js";
private static final String resourceName = "select2/current/dist/js/i18n/%s.js";
private static final String defaultLanguage = "en";

Expand All @@ -31,14 +31,10 @@ class Select2LanguageResourceReference extends WebjarsJavaScriptResourceReferenc
* @return resource name
*/
private static String getResourceName(String language) {
try {
String name = String.format(resourceName, language);
if (WebjarsJavaScriptResourceReference.class.getResource(name) != null) {
return name;
}
} catch (Exception ignore) {
// noop
if (isEmpty(language)) {
return String.format(resourceName, defaultLanguage);
}
return String.format(resourceName, defaultLanguage);

return String.format(resourceName, language);
}
}