Validate SQLite type

Author: wickwirew

Sources/Compiler/Sema/StmtTypeChecker.swift

@@ -891,12 +891,20 @@ extension StmtTypeChecker {
     }
 
     /// Will figure out the final SQL column type from the syntax
-    private func typeFor(column: borrowing ColumnDefSyntax) -> Type {
+    private mutating func typeFor(column: borrowing ColumnDefSyntax) -> Type {
         // Technically you can have a NULL primary key but I don't
         // think people actually do that...
         let isNotNullable = column.constraints
             .contains { $0.isPkConstraint || $0.isNotNullConstraint }
 
+        // Validate it is an actual SQLite type since SQlite doesnt care.
+        if !Type.validTypeNames.contains(column.type.name.value) {
+            diagnostics.add(.init(
+                "Invalid type '\(column.type.name.value)'",
+                at: column.type.location
+            ))
+        }
+        
         let nominal: Type = .nominal(column.type.name.value)
 
         let type: Type = if let alias = column.type.alias {

Sources/Compiler/Sema/Type.swift

@@ -110,6 +110,10 @@ public enum Type: Equatable, CustomStringConvertible, Sendable {
     static let blob: Type = .nominal("BLOB")
     static let any: Type = .nominal("ANY")
 
+    static let validTypeNames: Set<Substring> = [
+        "TEXT", "INT", "INTEGER", "REAL", "BLOB", "ANY"
+    ]
+    
     /// The underlying root inner type
     var root: Type {
         return switch self {

Tests/CompilerTests/Compiler/CompileCreateTable.sql

@@ -36,14 +36,15 @@ PRAGMA feather_require_strict_tables = TRUE;
 -- CHECK:   NAME baz
 -- CHECK:   COLUMNS
 -- CHECK:       KEY foo
--- CHECK:       VALUE TEXT?
+-- CHECK:       VALUE DECIMAL?
 -- CHECK:   PRIMARY_KEY
 -- CHECK:     foo
 -- CHECK:   KIND normal
 -- CHECK-ERROR: Missing STRICT table option
+-- CHECK-ERROR: Invalid type 'DECIMAL'
 -- CHECK-ERROR: Column 'bar' does not exist
 CREATE TABLE baz (
-    foo TEXT,
+    foo DECIMAL,
     PRIMARY KEY (foo, bar)
 );
 
@@ -70,7 +71,30 @@ CREATE TABLE qux (
 -- CHECK:       KEY TABLE
 -- CHECK:       VALUE KEY?
 -- CHECK:   KIND normal
+-- CHECK-ERROR: Invalid type 'KEY'
 CREATE TABLE "PRIMARY" (
     "TABLE" INTEGER,
     [TABLE] `KEY`
 ) STRICT;
+
+-- CHECK: TABLE
+-- CHECK:   NAME allValidTypes
+-- CHECK:   COLUMNS
+-- CHECK:       KEY int
+-- CHECK:       VALUE INT?
+-- CHECK:       KEY integer
+-- CHECK:       VALUE INTEGER?
+-- CHECK:       KEY text
+-- CHECK:       VALUE TEXT?
+-- CHECK:       KEY blob
+-- CHECK:       VALUE BLOB?
+-- CHECK:       KEY any
+-- CHECK:       VALUE ANY?
+-- CHECK:   KIND normal
+CREATE TABLE allValidTypes (
+    int INT,
+    integer INTEGER,
+    text TEXT,
+    blob BLOB,
+    any ANY
+) STRICT;