Skip to content

Commit cea273c

Browse files
committed
fix: revert css extraction (#332)
#327 broke embedded versions where the extractes CSS wasn't explicitly imported.
1 parent a1e8c94 commit cea273c

3 files changed

Lines changed: 1 addition & 19 deletions

File tree

js/package-lock.json

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
"eslint-config-airbnb-base": "^13.1.0",
4848
"eslint-plugin-import": "^2.17.2",
4949
"eslint-plugin-vue": "^5.2.2",
50-
"mini-css-extract-plugin": "^2.9.2",
5150
"npm-run-all": "^4.1.5",
5251
"postcss-loader": "^7.3.3",
5352
"postcss-scopify": "^1.0.0",

js/webpack.config.js

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
var path = require("path");
22
var version = require("./package.json").version;
3-
const MiniCssExtractPlugin = require("mini-css-extract-plugin");
43

54
// Custom webpack rules are generally the same for all webpack bundles, hence
65
// stored in a separate local variable.
@@ -131,23 +130,8 @@ module.exports = [
131130
},
132131
devtool: "source-map",
133132
module: {
134-
rules: [
135-
{
136-
test: /\.css$/,
137-
use: [MiniCssExtractPlugin.loader, "css-loader", "postcss-loader"],
138-
},
139-
{
140-
test: /\.(woff|woff2|eot|ttf|otf)$/,
141-
type: "asset/resource",
142-
},
143-
],
133+
rules,
144134
},
145-
// we extract the CSS to a separate file, since we might want to import it separately for global use
146-
plugins: [
147-
new MiniCssExtractPlugin({
148-
filename: "jupyter-vuetify.min.css",
149-
}),
150-
],
151135
externals: ["@jupyter-widgets/base", "@jupyterlab/apputils", "jupyter-vue"],
152136
resolve: {
153137
alias: {

0 commit comments

Comments
 (0)