docs: add deployer OTel SDK setup note to README#64
Conversation
Explains that commit-story ships with @opentelemetry/api only (a lightweight no-op peerDep) and that deployers who want trace data bring their own SDK. Points to examples/instrumentation.js, which was moved from src/instrumentation.js in the prior cleanup. Addresses spinybacked-orbweaver-eval#23.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates README.md with a new "Deployer SDK Setup" section documenting that Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Around line 175-177: The README shows using the Node CLI flag `--import` which
requires Node >=18.18.0, but package.json currently declares "engines": {"node":
">=18.0.0"} — update the package.json `engines.node` value to ">=18.18.0" (or
alternatively add a short note in the README next to the example explaining the
Node >=18.18.0 requirement) so the declared engine requirement matches the
`--import` dependency; target the `engines` entry in package.json (or the README
example text) when making the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
The --import CLI flag was backported to Node 18 only in v18.18.0. Add a parenthetical to the README example so deployers on older Node 18 patch versions know what's required. [skip ci]
Description
What does this PR do?
Adds a "Deployer SDK Setup" subsection to the Telemetry Schema section of the README, explaining that
commit-storyships with@opentelemetry/apionly (a lightweight no-op peerDep), that no OTel SDK is bundled, and thatexamples/instrumentation.jsis provided as a starting-point bootstrap for deployers who want trace data.Why is this change needed?
Without documentation, deployers have no way to discover that
examples/instrumentation.jsexists or understand the SDK-is-the-deployer's-choice contract. The code changes (@opentelemetry/sdk-nodemoved to devDependencies,src/instrumentation.jsrelocated toexamples/) were already in place — this is the final piece.Related Issues
Addresses spinybacked-orbweaver-eval#23.
Type of Change
Testing Checklist
Test results: README renders correctly. No code behavior changed — documentation only.
Security Checklist
Breaking Changes
Additional Context
Reviewer Notes: The package.json and file changes this documents were made in earlier commits —
@opentelemetry/sdk-nodeis already only indevDependencies, andinstrumentation.jsalready lives atexamples/. This PR closes the documentation gap.Summary by CodeRabbit