Skip to content

Commit 33142d1

Browse files
MatmaRexGerrit Code Review
authored andcommitted
Update git submodules
* Update OAuth from branch 'master' to 03670b2329f56a4b1535b2e53c43f17fe6ed39f8 - Migrate from wikimedia/oauth2-server fork to league/oauth2-server In order to migrate, we need to re-implement two things: - Issuer ('iss') claim thephpleague/oauth2-server#1138 This is easy: as advised on the pull request, we can just override AccessTokenTrait::convertToJWT() to do what we want. In fact, we already do this to change some other claims, so to avoid rewriting our code, we just need to add the field/setter/getter matching the rejected pull request. - Custom claims thephpleague/oauth2-server#1122 This is a bit trickier, since we need to know the grant type in order to generate our claims, and we don't know that in AccessTokenEntity. I added overrides to do it in the Grant classes that we use instead, in the method where the AccessTokenEntity is created. Then we add the field/setter/getter and a minimal ClaimEntity class matching the stalled pull request. The licenses of league/oauth2-server and this repository are not compatible, so I re-implemented the necessary features and did not copy the code. Depends-On: I37f0e614f088ab962d7064f2c7f763060283adae Bug: T261462 Change-Id: I5e8bcbe46b2d4aa8550beb7731aa2a1a70ecc139
1 parent c32591b commit 33142d1

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

OAuth

Submodule OAuth updated from 87728c3 to 03670b2

0 commit comments

Comments
 (0)