 }})
diff --git a/tests/Controller/OcrControllerTest.php b/tests/Controller/OcrControllerTest.php
index 1c5750af..0a07efe9 100644
--- a/tests/Controller/OcrControllerTest.php
+++ b/tests/Controller/OcrControllerTest.php
@@ -87,4 +87,66 @@ public function provideGetLang(): array {
],
];
}
+
+ /**
+ * @dataProvider provideRotationNormalization
+ * @covers OcrController
+ * @param int $inputRotation
+ * @param int $expectedRotation
+ */
+ public function testRotationNormalization( int $inputRotation, int $expectedRotation ): void {
+ $request = new Request( [ 'rotate' => $inputRotation ] );
+ $requestStack = new RequestStack();
+ $requestStack->push( $request );
+ $request->setSession( new Session( new MockArraySessionStorage() ) );
+ $intuition = new Intuition( [] );
+ $controller = new OcrController(
+ $requestStack,
+ $intuition,
+ new EngineFactory(
+ new GoogleCloudVisionEngine(
+ dirname( __DIR__ ) . '/fixtures/google-account-keyfile.json',
+ $intuition,
+ $this->projectDir,
+ new MockHttpClient()
+ ),
+ new TesseractEngine( new MockHttpClient(), $intuition, $this->projectDir, new TesseractOCR() ),
+ new TranskribusEngine(
+ new TranskribusClient(
+ getenv( 'APP_TRANSKRIBUS_USERNAME' ),
+ getenv( 'APP_TRANSKRIBUS_PASSWORD' ),
+ new MockHttpClient(),
+ new NullAdapter(),
+ new NullAdapter()
+ ),
+ $intuition,
+ $this->projectDir,
+ new MockHttpClient()
+ ),
+ ),
+ new FilesystemAdapter()
+ );
+ // Trigger the setup to process rotation
+ $reflection = new \ReflectionMethod( $controller, 'setup' );
+ $reflection->setAccessible( true );
+ $reflection->invoke( $controller );
+
+ $this->assertSame( $expectedRotation, OcrController::$params['rotate'] );
+ }
+
+ /**
+ * @return int[][]
+ */
+ public function provideRotationNormalization(): array {
+ return [
+ 'zero rotation' => [ 0, 0 ],
+ 'positive rotation' => [ 90, 90 ],
+ 'negative rotation' => [ -90, 270 ],
+ 'large positive rotation' => [ 450, 90 ],
+ 'large negative rotation' => [ -450, 270 ],
+ 'boundary 359' => [ 359, 359 ],
+ 'boundary 360' => [ 360, 0 ],
+ 'boundary -360' => [ -360, 0 ],
+ ];
+ }
}
diff --git a/tests/Engine/EngineBaseTest.php b/tests/Engine/EngineBaseTest.php
index 957e190f..84450760 100644
--- a/tests/Engine/EngineBaseTest.php
+++ b/tests/Engine/EngineBaseTest.php
@@ -205,4 +205,64 @@ public function instantiateEngine( string $engineName ): EngineBase {
}
return $engine;
}
+
+ /**
+ * @covers EngineBase::getResult
+ * Test that all engines accept the rotation parameter without errors
+ */
+ public function testEngineAcceptsRotationParameter(): void {
+ // Test that engines can be called with rotation parameter
+ // This is a smoke test to ensure rotation parameter doesn't break the interface
+ $this->tesseractEngine->setImageHosts( 'upload.wikimedia.org' );
+
+ // All engines should accept the rotation parameter in their signature
+ try {
+ // We don't expect actual OCR results here, just that the parameter is accepted
+ $reflection = new \ReflectionMethod( $this->tesseractEngine, 'getResult' );
+ $parameters = $reflection->getParameters();
+
+ // Check that 'rotate' parameter exists
+ $rotateParam = null;
+ foreach ( $parameters as $param ) {
+ if ( $param->getName() === 'rotate' ) {
+ $rotateParam = $param;
+ break;
+ }
+ }
+
+ $this->assertNotNull( $rotateParam, 'rotate parameter should exist in getResult()' );
+ $this->assertTrue( $rotateParam->isOptional(), 'rotate parameter should be optional' );
+ $this->assertSame( 0, $rotateParam->getDefaultValue(), 'rotate parameter should default to 0' );
+ } catch ( \Exception $e ) {
+ $this->fail( 'Failed to verify rotation parameter: ' . $e->getMessage() );
+ }
+ }
+
+ /**
+ * @covers EngineBase::getResult
+ * Test that rotation parameter is part of all engine interfaces
+ */
+ public function testAllEnginesHaveRotationParameter(): void {
+ $engines = [
+ $this->googleEngine,
+ $this->tesseractEngine,
+ $this->transkribusEngine,
+ ];
+
+ foreach ( $engines as $engine ) {
+ $reflection = new \ReflectionMethod( $engine, 'getResult' );
+ $parameters = $reflection->getParameters();
+
+ $paramNames = [];
+ foreach ( $parameters as $param ) {
+ $paramNames[] = $param->getName();
+ }
+
+ $this->assertContains(
+ 'rotate',
+ $paramNames,
+ 'Engine ' . get_class( $engine ) . ' should have rotate parameter'
+ );
+ }
+ }
}