feat!: Move MCP server features to default stability level #280
feat!: Move MCP server features to default stability level #280jmesnil wants to merge 2 commits into
Conversation
Promote the MCP subsystem, mcp-server layer, and required packages from experimental to default stability level. The XML namespace changes from urn:jboss:domain:mcp:experimental:1.0 to urn:jboss:domain:mcp:1.0. The testsuite/mcp provisions and runs WildFly at default stability. Fixes wildfly-extras#277 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…attributes Make sse-path, messages-path, and streamable-path optional with default values so they no longer need to be specified in the layer-spec. Rename timeout attribute to idle-timeout for clarity. Add validators and measurement unit. Improve descriptions in XSD and properties. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@pferraro Could you please review (in particular the first commit)? That's the first time, I'm promoting stability levels so I'm not sure if there is anything that I could have forgotten to do. thanks! |
| <property name="startupTimeoutInSeconds">120</property> | ||
| <property name="allowConnectingToRunningServer">false</property> | ||
| <property name="jbossArguments">--stability=experimental</property> | ||
| <property name="jbossArguments">--stability=default</property> |
There was a problem hiding this comment.
Just drop this property. The testsuite should run via the default stability of the server (i.e. community).
There was a problem hiding this comment.
mmh, but I want to ensure that the features work at the default stability level and not the default stability level (which is community for WildFly).
There was a problem hiding this comment.
The subsystem unit tests already validate the registration of the model when using default stability.
Integration tests for all features targeting Stability.DEFAULT are tested using the default stability for the WildFly server.
If they did not, the default behaviour for the majority of the server would be untested.
Why would this feature be any different?
|
|
||
| MCPSubsystemSchema(int major, int minor) { | ||
| this.namespace = SubsystemSchema.createLegacySubsystemURN(MCPSubsystemRegistrar.NAME, Stability.EXPERIMENTAL, new IntVersion(major, minor)); | ||
| this.namespace = SubsystemSchema.createLegacySubsystemURN(MCPSubsystemRegistrar.NAME, Stability.DEFAULT, new IntVersion(major, minor)); |
There was a problem hiding this comment.
This will break configurations migrated from previous versions.
To avoid that, we would normally keep the existing 1.0:experimental schema and add a new 1.0 schema.
There was a problem hiding this comment.
that's ok, we never published or released the 1.0:experimental schema (upcoming release will be the first with stability levels for the feature-pack's subsystems).
I keep that in mind for future releases though.
There was a problem hiding this comment.
Ah, ok. If 1.0:experimental was never released, then you can ignore most of the other comments.
| @Override | ||
| protected AdditionalInitialization createAdditionalInitialization() { | ||
| return AdditionalInitialization.withCapabilities(Stability.EXPERIMENTAL); | ||
| return AdditionalInitialization.withCapabilities(Stability.DEFAULT); | ||
| } |
There was a problem hiding this comment.
Drop this method override. The default implementation uses the stability of the test schema.
pferraro
left a comment
pferraro
left a comment
There was a problem hiding this comment.
The Stability.EXPERIMENTAL -> Stability.DEFAULT changes look good.
|
I'm closing this PR for the time being. I don't think the code is in the right shape to reach the |
3 participants
Promote the MCP subsystem, mcp-server layer, and required packages
from experimental to default stability level. The XML namespace
changes from urn:jboss:domain:mcp:experimental:1.0 to
urn:jboss:domain:mcp:1.0. The testsuite/mcp provisions and runs
WildFly at default stability.
Fixes #277