DRAFT: support 2024 edition, support decompose feature#103
Draft
hsqStephenZhang wants to merge 589 commits into
Draft
DRAFT: support 2024 edition, support decompose feature#103hsqStephenZhang wants to merge 589 commits into
hsqStephenZhang wants to merge 589 commits into
Conversation
Update focus mode UI
Allow pruning borrowcheck fact base when calculating aliases
Migrate indexed module into new indexical crate
chore: upgrade dependence
Update to nightly-2024-01-06
Update to nightly-2024-12-01
Update to nightly-2024-12-15, prepare 0.5.43
678d422 to
b1d22d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notice
though this PR has made
decomposefeature work, i haven't verified the solidity of the code, since there is a huge change of rustc apis. so i would like to make it a draft and lead to more discussions.i'm not sure why the github's PR page reports that there is a diff of nearly 600 commits, there is only 3 additional commits as shown my local machine (we could fix this later)
background
i'm studying data flow analysis and rust's static analysis frameworks, and i found this awesome project and the vscode extension, but it did not on my projects of 2024 edition. so i tried to fix the code
it turns out that
flowistrydoes not support rust 2024 edition(thoughrustc_pluginhas supported), and it will raise error msg for newly created projects.besides, the
decomposefeature is not full supported, and the release binary is not compile with this feature, so thedecomposecommand of vscode extension does not work.this version update & fix aim at solving the two problems.
solutions
version
nightly-2025-03-03, which is the same asrustc_plugin's.rustc_xxxusage and use the latest methods instead (it's dirty, but straightforward)indexicalinto the latest one, which supports 2024 editiondecompose feature
decomposecalling in extensiontest
currently, the download logic in extension.rs is commented out, and the test is done by both launching vscode extensionHost and install of vsix file.
edition test
decompose test
todo
download.tsbefore merging.rustc_pluginfix before merging