Merge pull request #175 from willdurand/bugfix/GH-174/repair-broken-npm-package-paths

fix for #174: create `npmrc` containing prefix to build package symlinks properly

(fixes #174)

Author: Ma27

.travis.yml

@@ -4,7 +4,6 @@ rvm:
   - 2.1.0
 
 env:
-  - PUPPET_VERSION="~> 3.4.0"
   - PUPPET_VERSION="~> 3.6.0"
   - PUPPET_VERSION="~> 3.7.0"
   - PUPPET_VERSION="~> 4.3.0"

Rakefile

@@ -6,6 +6,7 @@ require 'puppet_blacksmith/rake_tasks'
 PuppetLint.configuration.log_format       = "%{path}:%{line}:%{check}:%{KIND}:%{message}"
 PuppetLint.configuration.fail_on_warnings = false
 PuppetLint.configuration.send("disable_80chars")
+PuppetLint.configuration.send("disable_arrow_on_right_operand_line")
 
 exclude_paths = [
   "pkg/**/*",

manifests/instance.pp

@@ -130,6 +130,17 @@
       }
     }
 
+    $node_prefix = $target_dir
+    file { "nodejs-npmrc-etc-dir-${version}":
+      ensure => directory,
+      path   =>  "${node_unpack_folder}/etc",
+    } ->
+    file { "nodejs-npmrc-${version}":
+      ensure  => present,
+      path    => "${node_unpack_folder}/etc/npmrc",
+      content => template("${module_name}/npmrc")
+    }
+
     file { "nodejs-symlink-bin-with-version-${version}":
       ensure => 'link',
       path   => $node_symlink,

spec/defines/nodejs_instance_spec.rb

@@ -112,6 +112,15 @@
       .with_content(/(.*)\/usr\/local\/bin\/node-v6.0.0 \/usr\/local\/node\/node-v6.0.0\/bin\/npm "\$@"/)
     }
 
+    it { should contain_file('nodejs-npmrc-etc-dir-v6.0.0') \
+      .with_ensure('directory') \
+      .with_path('/usr/local/node/node-v6.0.0/etc')
+    }
+
+    it { should contain_file('nodejs-npmrc-v6.0.0') \
+      .with_path('/usr/local/node/node-v6.0.0/etc/npmrc')
+    }
+
     it { should_not contain_file('/usr/local/bin/node') }
     it { should_not contain_file('/usr/local/bin/npm') }
 

templates/npmrc

@@ -0,0 +1 @@
+prefix=<%= @node_prefix.sub '/bin', '' %>