Refactor ChineseRemainderTheorem: reuse PrimeFactorization, add tests#1314
Merged
williamfiset merged 5 commits intomasterfrom Apr 2, 2026
Merged
Refactor ChineseRemainderTheorem: reuse PrimeFactorization, add tests#1314williamfiset merged 5 commits intomasterfrom
williamfiset merged 5 commits intomasterfrom
Conversation
Remove duplicated primeFactorization, pollardRho, isPrime, and gcf methods in favor of the shared PrimeFactorization class. Simplify prime-power grouping loop and clean up Javadoc. Add 17 JUnit 5 tests covering eliminateCoefficient, crt, reduce, egcd, and full reduce+crt integration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Restore primeFactorization, pollardRho, isPrime, and supporting methods as private methods within ChineseRemainderTheorem rather than delegating to PrimeFactorization. Uses the improved Miller-Rabin primality test and overflow-safe mulMod instead of the original trial-division isPrime. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
primeFactorization,pollardRho,isPrime,gcf) and delegate to the sharedPrimeFactorizationclassListIterator-based prime-power grouping with a cleaner index-based loop@linkreferences and Unicode math notationeliminateCoefficient,crt,reduce,egcd, and full reduce+crt integrationTest plan
bazel test //src/test/java/com/williamfiset/algorithms/math:ChineseRemainderTheoremTest— all 17 tests pass🤖 Generated with Claude Code