Refactor ModPow: fix overflow, simplify loop, add tests#1315
Merged
williamfiset merged 1 commit intomasterfrom Apr 2, 2026
Merged
Refactor ModPow: fix overflow, simplify loop, add tests#1315williamfiset merged 1 commit intomasterfrom
williamfiset merged 1 commit intomasterfrom
Conversation
Replace fragile MAX/MIN overflow guards with overflow-safe mulMod via BigInteger, supporting the full long range. Simplify the bit-mask exponentiation loop to standard binary exponentiation. Remove inline main() test code and add 11 JUnit 5 tests including a randomized check against BigInteger.modPow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX/MINoverflow guards with overflow-safemulModviaBigInteger, supporting the fulllongrange[0, mod)upfront instead of repeated+mod % modin the loopmain()and inline test helpers (randLong,RANDOM)BigInteger.modPowTest plan
bazel test //src/test/java/com/williamfiset/algorithms/math:ModPowTest— all 11 tests pass🤖 Generated with Claude Code