Refactor HashTableOpenAddressingBase: consolidate API and enhance docs#1317
Merged
williamfiset merged 1 commit intomasterfrom Apr 3, 2026
Merged
Refactor HashTableOpenAddressingBase: consolidate API and enhance docs#1317williamfiset merged 1 commit intomasterfrom
williamfiset merged 1 commit intomasterfrom
Conversation
Remove insert/hasKey/add aliases in favor of put/containsKey directly, add ConcurrentModificationException check in iterator's next(), remove redundant iterator remove(), and expand class-level and inline educational commentary explaining open addressing, tombstones, probe chains, and lazy relocation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
insert/hasKey/addmethod aliases — callers now useputandcontainsKeydirectlyConcurrentModificationExceptioncheck in iterator'snext()and remove redundantremove()overrideput/containsKey)Test plan
bazel test //src/test/java/.../hashtable/...)🤖 Generated with Claude Code