-
Notifications
You must be signed in to change notification settings - Fork 6
Support Seq servers that do not expose the Scan link #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aarondglover
wants to merge
5
commits into
willibrandon:main
Choose a base branch
from
aarondglover:fix/seqsearch-scan-compat-net10
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
aa2086c
Support Seq servers without the Scan link
aarondglover 636b983
Split Seq integration coverage into legacy fallback and modern Scan f…
Copilot 73e9f75
Merge branch 'willibrandon:main' into copilot/research-seq-scan-compa…
aarondglover bed6b83
Address review: probe Links.ContainsKey instead of catching, pin lega…
Copilot 8465322
Merge pull request #1 from aarondglover/copilot/research-seq-scan-com…
aarondglover File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads-up on the modern-fixture CI failure: Seq 2025.x refuses to start unless either an admin password is supplied or
SEQ_FIRSTRUN_NOAUTHENTICATION=trueis set in the container env, so the container exits immediately and the readiness loop just hits "Connection refused" through the full retry budget. Adding.WithEnvironment("SEQ_FIRSTRUN_NOAUTHENTICATION", "true")here should unblock CI.Tangentially — the modern fixture uses
datalust/seq:2025.2(floating), same drift concern that motivated pinning2024.3.13181. Worth pinning a specific patch like2025.2.16202while you're in here.