refactor: notification settings overhaul cleanup (#150)

Author: williscool

android/app/src/main/java/com/github/quarck/calnotify/notification/NotificationChannels.kt

@@ -39,7 +39,9 @@ object NotificationChannels {
     const val GROUP_ID_ALARM = "group_alarm"
     const val GROUP_ID_SILENT = "group_silent"
 
-    // Channel IDs - these are user-visible in system settings
+    // Channel IDs - IMPORTANT: These must match the string resources in strings.xml
+    // (channel_id_default, channel_id_alarm, etc.) which are used by XML preferences.
+    // See NotificationChannelsRobolectricTest for sync verification.
     const val CHANNEL_ID_DEFAULT = "calendar_events"
     const val CHANNEL_ID_ALARM = "calendar_alarm"
     const val CHANNEL_ID_SILENT = "calendar_silent"

android/app/src/main/java/com/github/quarck/calnotify/prefs/RingtonePreferenceX.kt

@@ -373,6 +373,14 @@
     <string name="alarm_tag">#alarm</string>
     <string name="create_event">Create Event</string>
 
+    <!-- Notification channel IDs (not translatable - must match NotificationChannels.kt constants) -->
+    <string name="channel_id_default" translatable="false">calendar_events</string>
+    <string name="channel_id_alarm" translatable="false">calendar_alarm</string>
+    <string name="channel_id_silent" translatable="false">calendar_silent</string>
+    <string name="channel_id_reminders" translatable="false">calendar_reminders</string>
+    <string name="channel_id_alarm_reminders" translatable="false">calendar_alarm_reminders</string>
+    
+    <!-- Notification channel display names -->
     <string name="notification_channel_default">Calendar Events</string>
     <string name="notification_channel_default_desc">Default channel for calendar events</string>
     <string name="notification_channel_alarm">Alarm Notifications</string>

android/app/src/main/res/values/strings.xml

@@ -22,7 +22,7 @@
             android:key="pref_key_ringtone"
             android:title="@string/ringtone_calendar_events"
             android:ringtoneType="notification"
-            app:channelId="calendar_events" />
+            app:channelId="@string/channel_id_default" />
 
         <Preference
             android:key="pref_all_sound_notification_channels"

android/app/src/main/res/xml/notification_preferences_x.xml

@@ -34,7 +34,7 @@
         android:title="@string/ringtone_reminder"
         android:ringtoneType="notification"
         android:dependency="reminders_custom_ringtone"
-        app:channelId="calendar_reminders" />
+        app:channelId="@string/channel_id_reminders" />
 
     <CheckBoxPreference
         android:key="reminders_custom_vibration"

android/app/src/main/res/xml/reminder_preferences_x.xml

@@ -261,5 +261,43 @@ class NotificationChannelsRobolectricTest {
         // Assert
         assertEquals("Silent", title)
     }
+
+    // === String resource sync tests ===
+    // These tests ensure the Kotlin constants match the string resources used in XML preferences
+
+    @Test
+    fun `channel ID constants match string resources - default`() {
+        val stringResource = context.getString(com.github.quarck.calnotify.R.string.channel_id_default)
+        assertEquals("Channel ID constant must match string resource",
+            NotificationChannels.CHANNEL_ID_DEFAULT, stringResource)
+    }
+
+    @Test
+    fun `channel ID constants match string resources - alarm`() {
+        val stringResource = context.getString(com.github.quarck.calnotify.R.string.channel_id_alarm)
+        assertEquals("Channel ID constant must match string resource",
+            NotificationChannels.CHANNEL_ID_ALARM, stringResource)
+    }
+
+    @Test
+    fun `channel ID constants match string resources - silent`() {
+        val stringResource = context.getString(com.github.quarck.calnotify.R.string.channel_id_silent)
+        assertEquals("Channel ID constant must match string resource",
+            NotificationChannels.CHANNEL_ID_SILENT, stringResource)
+    }
+
+    @Test
+    fun `channel ID constants match string resources - reminders`() {
+        val stringResource = context.getString(com.github.quarck.calnotify.R.string.channel_id_reminders)
+        assertEquals("Channel ID constant must match string resource",
+            NotificationChannels.CHANNEL_ID_REMINDERS, stringResource)
+    }
+
+    @Test
+    fun `channel ID constants match string resources - alarm reminders`() {
+        val stringResource = context.getString(com.github.quarck.calnotify.R.string.channel_id_alarm_reminders)
+        assertEquals("Channel ID constant must match string resource",
+            NotificationChannels.CHANNEL_ID_ALARM_REMINDERS, stringResource)
+    }
 }