refactor: room integration POC (#134)

* docs: room integration

* ci: POC that builds on linux

* fix: back to ksp

* test: closer to passing

* ci: .gitignore update

* test: a version of the poc tests that pass

* fix: code cleanup and docs about how we got it working

* fix: rollback bidirectional sync changes that aren't ready to go yet

just did them to verify crsqlite was working

* docs: plan update

* docs: update

* fix: dramatically simplify with RequerySQLiteOpenHelperFactory

* fix: even simpler

* fix: scripts/build_crsqlite_arm64

* ci: hopefully fix report retrival contention

refs #136

Author: williscool

.gitignore

@@ -161,6 +161,7 @@ out/
 
 # Gradle files
 .gradle/
+android/.kotlin/
 build/
 !docs/build/
 

android/app/build.gradle

@@ -4,6 +4,7 @@ plugins {
     id 'kotlinx-serialization'
     id 'jacoco'
     id 'com.facebook.react'
+    id 'com.google.devtools.ksp'  // Using KSP for Room (avoids SQLite JDBC issue on Windows)
 }
 
 //
@@ -60,6 +61,9 @@ android {
       force 'org.objenesis:objenesis:3.3'
       force 'net.bytebuddy:byte-buddy:1.14.11'
       force 'net.bytebuddy:byte-buddy-agent:1.14.11'
+      // Force sqlite version for Room 2.8.4 compatibility (overrides consistent resolution constraint)
+      force 'androidx.sqlite:sqlite:2.6.2'
+      force 'androidx.sqlite:sqlite-framework:2.6.2'
     }
   }
 
@@ -72,6 +76,9 @@ android {
       excludes += ['META-INF/AL2.0']
       excludes += ['META-INF/LGPL2.1']
     }
+    jniLibs {
+      useLegacyPackaging = true
+    }
     pickFirst '**/*.so'
   }
 
@@ -226,6 +233,9 @@ android {
 // React Native configuration for RN 0.76+
 // NOTE: All react {} configuration is consolidated at the bottom of this file
 
+// KSP avoids the SQLite JDBC native library extraction issue that KAPT has on Windows
+// Room arguments can be passed via: ksp { arg("room.schemaLocation", "...") } if needed
+
 dependencies {
     implementation fileTree(dir: 'libs', include: ['*.jar'])
 
@@ -333,6 +343,19 @@ dependencies {
 
     // Jacoco
     androidTestImplementation 'org.jacoco:org.jacoco.core:0.8.12'
+    
+    // Room POC (test only - verifying cr-sqlite compatibility)
+    // See docs/dev_todo/database_modernization_plan.md
+    // Note: Room 2.7.0+ required for Kotlin 2.0.x metadata compatibility
+    // https://developer.android.com/jetpack/androidx/releases/room
+    def roomVersion = "2.8.4"
+    androidTestImplementation "androidx.room:room-runtime:$roomVersion"
+    androidTestImplementation "androidx.room:room-ktx:$roomVersion"
+    androidTestImplementation "androidx.room:room-testing:$roomVersion"
+    kspAndroidTest "androidx.room:room-compiler:$roomVersion"
+    // Room 2.8+ uses the new androidx.sqlite library
+    androidTestImplementation "androidx.sqlite:sqlite:2.6.2"
+    androidTestImplementation "androidx.sqlite:sqlite-framework:2.6.2"
 }
 
 // https://reactnative.dev/docs/react-native-gradle-plugin

android/app/src/androidTest/java/com/github/quarck/calnotify/database/poc/CrSqliteSupportHelper.kt

@@ -0,0 +1,79 @@
+//
+//   Calendar Notifications Plus
+//   Copyright (C) 2025 William Harris (wharris+cnplus@upscalews.com)
+//
+//   This program is free software; you can redistribute it and/or modify
+//   it under the terms of the GNU General Public License as published by
+//   the Free Software Foundation; either version 3 of the License, or
+//   (at your option) any later version.
+//
+//   This program is distributed in the hope that it will be useful,
+//   but WITHOUT ANY WARRANTY; without even the implied warranty of
+//   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+//   GNU General Public License for more details.
+//
+//   You should have received a copy of the GNU General Public License
+//   along with this program; if not, write to the Free Software Foundation,
+//   Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA
+//
+
+package com.github.quarck.calnotify.database.poc
+
+import androidx.sqlite.db.SupportSQLiteOpenHelper
+import com.github.quarck.calnotify.logs.DevLog
+import io.requery.android.database.sqlite.RequerySQLiteOpenHelperFactory
+import io.requery.android.database.sqlite.SQLiteCustomExtension
+import io.requery.android.database.sqlite.SQLiteDatabaseConfiguration
+
+/**
+ * SupportSQLiteOpenHelper.Factory that uses requery with cr-sqlite extension.
+ * 
+ * Uses RequerySQLiteOpenHelperFactory's ConfigurationOptions to add cr-sqlite,
+ * and wraps the helper to ensure crsql_finalize() is called on close.
+ * 
+ * See: https://github.com/requery/sqlite-android#support-library-compatibility
+ * See: docs/testing/crsqlite_room_testing.md
+ */
+class CrSqliteRoomFactory : SupportSQLiteOpenHelper.Factory {
+    
+    companion object {
+        private const val LOG_TAG = "CrSqliteRoomFactory"
+    }
+
+    // ConfigurationOptions that adds cr-sqlite extension
+    private val crSqliteOptions = object : RequerySQLiteOpenHelperFactory.ConfigurationOptions {
+        override fun apply(config: SQLiteDatabaseConfiguration): SQLiteDatabaseConfiguration {
+            config.customExtensions.add(
+                SQLiteCustomExtension("crsqlite_requery", "sqlite3_crsqlite_init")
+            )
+            DevLog.info(LOG_TAG, "Added cr-sqlite extension to configuration")
+            return config
+        }
+    }
+
+    // Requery's factory with our cr-sqlite configuration
+    private val requeryFactory = RequerySQLiteOpenHelperFactory(listOf(crSqliteOptions))
+
+    override fun create(configuration: SupportSQLiteOpenHelper.Configuration): SupportSQLiteOpenHelper {
+        val requeryHelper = requeryFactory.create(configuration)
+        return CrSqliteFinalizeWrapper(requeryHelper)
+    }
+}
+
+/**
+ * Wrapper that ensures crsql_finalize() is called before close.
+ * Uses Kotlin delegation - only overrides close().
+ */
+class CrSqliteFinalizeWrapper(
+    private val delegate: SupportSQLiteOpenHelper
+) : SupportSQLiteOpenHelper by delegate {
+
+    override fun close() {
+        try {
+            writableDatabase.query("SELECT crsql_finalize()").use { it.moveToFirst() }
+        } catch (e: Exception) {
+            DevLog.error("CrSqliteFinalizeWrapper", "Error calling crsql_finalize: ${e.message}")
+        }
+        delegate.close()
+    }
+}