test: fix local flakiness in notification dismiss (#147)

Author: williscool

android/app/src/androidTest/java/com/github/quarck/calnotify/testutils/UITestFixture.kt

@@ -179,6 +179,8 @@ class UITestFixture {
     /**
      * Sets up lightweight mocking to prevent calendar reloads from clearing test events.
      * This mocks ApplicationController.onMainActivityResumed to skip the calendar rescan.
+     * Also mocks alarm-triggered notification posting to prevent flaky tests from stale
+     * AlarmManager alarms that persist across test runs on local emulators.
      */
     private fun setupCalendarReloadPrevention() {
         DevLog.info(LOG_TAG, "Setting up calendar reload prevention")
@@ -196,6 +198,17 @@ class UITestFixture {
             ApplicationController.onCalendarChanged(any()) 
         } just Runs
 
+        // Mock alarm-triggered methods to prevent notifications from stale AlarmManager alarms.
+        // Local emulators persist alarms across test runs, causing flaky notification interference.
+        // (GitHub Actions uses fresh emulators so this is less common there.)
+        every { 
+            ApplicationController.onEventAlarm(any()) 
+        } just Runs
+        
+        every { 
+            ApplicationController.fireEventReminder(any(), any(), any()) 
+        } just Runs
+        
         calendarReloadPrevented = true
         DevLog.info(LOG_TAG, "Calendar reload prevention active")
     }
@@ -551,6 +564,9 @@ class UITestFixture {
 
     /**
      * Launches MainActivity with ActivityScenario.
+     * 
+     * If calendar reload prevention is active, also clears any pre-existing notifications
+     * to prevent them from interfering with UI tests (e.g., blocking toolbar buttons).
      */
     fun launchMainActivity(): ActivityScenario<MainActivity> {
         DevLog.info(LOG_TAG, "Launching MainActivity")
@@ -560,6 +576,13 @@ class UITestFixture {
             DevLog.info(LOG_TAG, "MainActivity is ready: ${activity.javaClass.simpleName}")
         }
         dismissStartupDialogs()
+        
+        // Clear any pre-existing notifications that could interfere with UI tests
+        // (e.g., heads-up notifications blocking toolbar buttons)
+        if (calendarReloadPrevented) {
+            cancelAllNotifications()
+        }
+        
         return scenario
     }
 

android/app/src/androidTest/java/com/github/quarck/calnotify/ui/MainActivityTest.kt

@@ -298,7 +298,6 @@ class MainActivityTest : BaseUltronTest() {
 
     @Test
     fun search_filters_events() {
-        fixture.cancelAllNotifications()
         fixture.createEvent(title = "Alpha Meeting")
         fixture.createEvent(title = "Beta Meeting")
 
@@ -324,7 +323,6 @@ class MainActivityTest : BaseUltronTest() {
 
     @Test
     fun first_back_press_hides_keyboard_keeps_filter() {
-        fixture.cancelAllNotifications()
         fixture.createEvent(title = "Alpha Meeting")
         fixture.createEvent(title = "Beta Meeting")
 
@@ -356,7 +354,6 @@ class MainActivityTest : BaseUltronTest() {
 
     @Test
     fun second_back_press_clears_filter() {
-        fixture.cancelAllNotifications()
         fixture.createEvent(title = "Alpha Meeting")
         fixture.createEvent(title = "Beta Meeting")