Commit 0fd08c0
authored
ci: enable ATIF S3 storage tests (NVIDIA#168)
#### Overview
Enable CI coverage for the ATIF S3 storage integration test by running it against an ephemeral S3-compatible service.
- [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license.
- [x] I searched existing issues and open pull requests, and this does not duplicate existing work.
#### Details
- Add an `adobe/s3mock:5.0.0` service to the Linux Rust CI lane.
- Pre-create the ATIF test bucket in S3Mock and enable `NEMO_RELAY_RUN_S3_TESTS` for `linux-amd64`.
- Export local S3 endpoint, region, dummy credentials, HTTP allowance, and path-style addressing for the existing ATIF S3 integration test.
Validation run locally:
- `ruby -e 'require "yaml"; YAML.load_file(".github/workflows/ci_rust.yml"); puts "yaml-ok"'`
- `cargo test -p nemo-relay --test atif_storage_integration`
- `uv run pre-commit run --files .github/workflows/ci_rust.yml`
- `git diff --check`
Note: local Docker is not installed in this environment, so the live S3Mock container path is expected to be validated by CI.
#### Where should the reviewer start?
Start with `.github/workflows/ci_rust.yml`, especially the new `s3` service and the environment exported when `matrix.run_s3_tests` is true.
#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
- Relates to: none
## Summary by CodeRabbit
* **Chores**
* CI enhanced to run S3 integration tests on supported Linux AMD64 runners with S3 mock service; environment variables for S3 access are now provided during those tests.
* **Tests**
* Integration test expectation updated: uploaded trajectory metadata now reports schema version "ATIF-v1.7".
[](https://app.coderabbit.ai/change-stack/NVIDIA/NeMo-Relay/pull/168?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)
Authors:
- Will Killian (https://github.com/willkill07)
Approvers:
- David Gardner (https://github.com/dagardner-nv)
URL: NVIDIA#1681 parent 5687372 commit 0fd08c0
2 files changed
Lines changed: 26 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
47 | 58 | | |
48 | 59 | | |
49 | 60 | | |
50 | 61 | | |
51 | 62 | | |
52 | 63 | | |
53 | 64 | | |
54 | | - | |
55 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
56 | 68 | | |
57 | 69 | | |
58 | 70 | | |
59 | 71 | | |
| 72 | + | |
60 | 73 | | |
61 | 74 | | |
62 | 75 | | |
63 | 76 | | |
64 | 77 | | |
| 78 | + | |
65 | 79 | | |
66 | 80 | | |
67 | 81 | | |
68 | 82 | | |
69 | 83 | | |
| 84 | + | |
70 | 85 | | |
71 | 86 | | |
72 | 87 | | |
73 | 88 | | |
74 | 89 | | |
| 90 | + | |
75 | 91 | | |
76 | 92 | | |
77 | 93 | | |
| |||
145 | 161 | | |
146 | 162 | | |
147 | 163 | | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | 164 | | |
152 | 165 | | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
153 | 173 | | |
154 | 174 | | |
155 | 175 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
203 | | - | |
| 203 | + | |
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
| |||
0 commit comments