Commit c02d24c
authored
ci: update Cargo Artifactory publishing config (NVIDIA#68)
#### Overview
Updates the scheduled Cargo Artifactory publish job so Cargo publishing no longer configures Git credential storage or derives a Basic auth credential from the Artifactory username and key. The job now uses the Artifactory key directly as the Cargo publish token and keeps registry configuration limited to the Artifactory sparse index.
- [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license.
- [x] I searched existing issues and open pull requests, and this does not duplicate existing work.
#### Details
- Remove the Cargo publish job's `NEMO_FLOW_CI_ARTIFACTORY_USER` requirement.
- Remove `git_credential_url`, global Git credential helper setup, `.git-credentials` writes, and `git-fetch-with-cli` configuration from the Cargo publish path.
- Remove the now-unused Basic auth token derivation and Cargo credential-provider setting.
- Configure `~/.cargo/config.toml` with an Artifactory sparse registry entry: `sparse+${NEMO_FLOW_CI_ARTIFACTORY_CARGO_URL}`.
- Pass `${NEMO_FLOW_CI_ARTIFACTORY_KEY}` directly to `cargo publish --token` for each Rust crate.
Validation:
- Inspected `git diff upstream/main...HEAD -- .gitlab-ci.yml`
- Confirmed the PR branch changes only `.gitlab-ci.yml`
#### Where should the reviewer start?
Start with `.gitlab-ci.yml`, specifically the `publish:artifactory:cargo` job script.
#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
- Relates to: NVIDIA#64 NVIDIA#60 NVIDIA#59
## Summary by CodeRabbit
* **Chores**
* Simplified Cargo crate publishing configuration in CI/CD pipeline, reducing configuration complexity and credential management requirements while maintaining publishing functionality.
Authors:
- Will Killian (https://github.com/willkill07)
Approvers:
- David Gardner (https://github.com/dagardner-nv)
URL: NVIDIA#681 parent 7744e0a commit c02d24c
1 file changed
Lines changed: 5 additions & 39 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
235 | | - | |
236 | | - | |
| 235 | + | |
| 236 | + | |
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
| |||
260 | 260 | | |
261 | 261 | | |
262 | 262 | | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | | - | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | | - | |
282 | | - | |
283 | | - | |
284 | | - | |
285 | | - | |
286 | 263 | | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | | - | |
292 | | - | |
| 264 | + | |
| 265 | + | |
293 | 266 | | |
294 | 267 | | |
295 | | - | |
296 | | - | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | | - | |
302 | 268 | | |
303 | | - | |
| 269 | + | |
304 | 270 | | |
305 | 271 | | |
306 | 272 | | |
| |||
0 commit comments