Rework calm hub commands to work with new $id-driven API structure (finos#2662)

* feat(cli): rework push commands

* feat(shared): mapping endpoints in calm-hub-client

* feat(cli): rework pull commands to focus on mappings

* feat(cli): rewrite of calm hub commands v1

* docs: TEMP TODO

* fix(cli): sort versions returned from calmhub

* fix(cli): update document before pushing to handle version changes

* fix(cli): rework non-control list commands and improve validation

* fix(cli): dead code and tests

* feat(cli): rework to support controls

* fix(shared): domain tests

* fix(cli): lint

* fix(cli): pull in latest package lock from main

* fix(cli): remove old semver file

* fix: clean up TODOs

* fix: cleanup document-id-utils

* refactor(cli): remove redundant method

* docs(cli): rewrite of cli docs for new hub commands

* fix(cli): fix issue with version bumps

* test(cli): improve coverage

* test(cli): coverage

* test(cli): cover auth plugin loading branches in parseDocumentLoaderConfig

CI was getting 84.86% branch coverage (below 85% threshold) because the
auth plugin loading code was only covered locally by accidentally reading
~/.calm.json. Add proper unit tests for both the success and error paths.

* fix(cli): fix output bug

* fix(cli): pr feedback

---------

Co-authored-by: jpgough-ms <152306432+jpgough-ms@users.noreply.github.com>
Co-authored-by: Matthew Bain <66839492+rocketstack-matt@users.noreply.github.com>

Author: 3 people

cli/src/cli.spec.ts

@@ -246,4 +246,15 @@ describe('runTimelineDiffCommand', () => {
 
         expect(mocks.processExit).toHaveBeenCalledWith(1);
     });
+
+    it('does not append a trailing newline when summary output already ends with one', async () => {
+        (runTimelineDiff as unknown as ReturnType<typeof vi.fn>).mockResolvedValue({
+            diffs: [{ from: 'm1', to: 'm2', diff: emptyDiff }],
+        });
+
+        await runTimelineDiffCommand({ ...timelineBaseOptions, outputFormat: 'summary' as const });
+
+        // formatDiff in 'summary' mode ends with '\n', so the extra write should NOT occur
+        expect(mocks.stdoutWrite).toHaveBeenCalledTimes(1);
+    });
 });

cli/src/cli.ts

@@ -102,6 +102,13 @@ describe('buildImpliedTimeline', () => {
 
         expect(timeline.moments[0].name).toBe('broken');
     });
+
+    it('returns timeline without current-moment when given no architectures', () => {
+        const timeline = buildImpliedTimeline([]);
+
+        expect(timeline.moments).toHaveLength(0);
+        expect(timeline['current-moment']).toBeUndefined();
+    });
 });
 
 describe('runTimelineGenerate', () => {
@@ -135,4 +142,14 @@ describe('runTimelineGenerate', () => {
         expect(exitSpy).toHaveBeenCalledWith(1);
     });
 
+    it('handles non-Error thrown values in the catch block', () => {
+        const a = writeArch('a.json', { name: 'A' });
+        const exitSpy = vi.spyOn(process, 'exit').mockImplementation((() => undefined) as never);
+        vi.spyOn(process.stdout, 'write').mockImplementation(() => { throw 'non-error string'; });
+
+        runTimelineGenerate({ architecturePaths: [a], verbose: false });
+
+        expect(exitSpy).toHaveBeenCalledWith(1);
+    });
+
 });

cli/src/command-helpers/diff.spec.ts

@@ -247,6 +247,21 @@ describe('runValidate', () => {
         expect(writeFileSync).toHaveBeenCalledWith('out.json', 'formatted output');
     });
 
+    it('should exit 1 when neither architecture, pattern, nor timeline is resolved', async () => {
+        await runValidate({
+            architecturePath: undefined,
+            patternPath: undefined,
+            timelinePath: undefined,
+            metaSchemaPath: 'schemas',
+            verbose: false,
+            outputFormat: 'json',
+            outputPath: '',
+            strict: false,
+        });
+
+        expect(mocks.processExit).toHaveBeenCalledWith(1);
+    });
+
     it('should call process.exit(1) when an error occurs', async () => {
         const options: ValidateOptions = {
             architecturePath: 'arch.json',