fix: persist custom jog key mappings across restart#3136
Merged
Conversation
Collaborator
|
Nice, thanks for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom jog key mappings are now persisted, so remapped jog keys survive an application restart instead of resetting to defaults. The action-registration path preserves the user's stored jog keybindings when registering actions.
Why this matters
Issue #3022 reports that jog keymap changes do not stick: after remapping jog keys and restarting UGS, the bindings revert to the defaults.
ActionRegistrationServicere-registered jog actions without honoring the persisted key mappings, so the saved bindings were effectively discarded on startup.This makes action registration respect the stored jog keybindings, so a user's customized jog keys are reapplied on restart. Default behavior for users who never remapped anything is unchanged.
Testing
mvn testonActionRegistrationServiceTestpasses, with new coverage asserting that persisted jog key mappings are retained through action registration (a remapped binding is preserved rather than overwritten by the default).Fixes #3022