Record::wrap() ignore readonly or virtual #1256

Author: asika32764

src/RecordTrait.php

@@ -11,6 +11,7 @@
 use Windwalker\Utilities\Classes\TraitHelper;
 use Windwalker\Utilities\TypeCast;
 
+use function Windwalker\get_object_dump_props;
 use function Windwalker\get_object_dump_values;
 
 trait RecordTrait
@@ -84,7 +85,23 @@ public function merge(mixed $values, bool $recursive = false, bool $ignoreNulls
     {
         $values = TypeCast::toArray($values);
 
+        $props = get_object_dump_props($this, ignores: $ignores);
+
         foreach ($values as $key => $value) {
+            $propRef = $props[$key] ?? $ignores[$key] ?? null;
+
+            if (
+                $propRef
+                && (
+                    $propRef->isPrivate()
+                    || $propRef->isProtected()
+                    || $propRef->isVirtual()
+                    || $propRef->isReadOnly()
+                )
+            ) {
+                continue;
+            }
+
             if (
                 $recursive
                 && is_object($this->$key ?? null)
@@ -103,6 +120,7 @@ public function merge(mixed $values, bool $recursive = false, bool $ignoreNulls
         return $this;
     }
 
+    #[\NoDiscard]
     public function withMerge(mixed $values, bool $recursive = false, bool $ignoreNulls = false): static
     {
         return (clone $this)->merge($values, $recursive, $ignoreNulls);
@@ -115,13 +133,15 @@ public function defaults(mixed $values, bool $recursive = false): static
         return $this->merge($values, $recursive)->merge($new, $recursive, true);
     }
 
+    #[\NoDiscard]
     public function withDefaults(mixed $values, bool $recursive = false): static
     {
         $new = clone $this;
 
         return (clone $this)->merge($values, $recursive)->merge($new, $recursive, true);
     }
 
+    #[\NoDiscard]
     public function with(...$data): static
     {
         if (PHP_VERSION_ID >= 80500) {