fix: [CCM-32115]: Updated error log handing for errors while scraping (#47)

* 201a0a fix: [CCM-32115]: Using logger with fields

* f23259 fix: [CCM-32115]: Restricting fetching price for the me-south-1 reagion due to middle-ease crisis

* 3a3ef1 fix: [CCM-32115]: Updated error log handing for errors while scraping

Author: Challa Reddy

internal/cloudinfo/providers/amazon/cloudinfo.go

@@ -39,8 +39,9 @@ import (
 )
 
 const (
-	svcEks = "eks"
-	svcPKE = "pke"
+	svcEks           = "eks"
+	svcPKE           = "pke"
+	restrictedRegion = "me-south-1"
 )
 
 // Ec2Infoer encapsulates the data and operations needed to access external resources
@@ -512,6 +513,10 @@ func (e *Ec2Infoer) getCurrentSpotPrices(region string) (map[string]types.SpotPr
 
 // GetCurrentPrices returns the current spot prices of every instance type in every availability zone in a given region
 func (e *Ec2Infoer) GetCurrentPrices(region string) (map[string]types.Price, error) {
+	if region == restrictedRegion {
+		log.WithFields(e.log, map[string]any{"region": region}).Info("skipping region due to connectivity restrictions")
+		return nil, nil
+	}
 	logger := log.WithFields(e.log, map[string]interface{}{"region": region})
 	var spotPrices map[string]types.SpotPriceInfo
 	var err error
@@ -526,7 +531,6 @@ func (e *Ec2Infoer) GetCurrentPrices(region string) (map[string]types.Price, err
 		logger.Debug("getting current spot prices directly from the AWS API")
 		spotPrices, err = e.getCurrentSpotPrices(region)
 		if err != nil {
-			logger.Error("failed to retrieve current spot prices")
 			return nil, err
 		}
 	}

internal/cloudinfo/scrape.go

@@ -250,8 +250,6 @@ func (sm *scrapingManager) scrapeServiceInformation(ctx context.Context) {
 
 	err := sm.scrapeServiceRegionInfo(ctx, storedServices)
 	if err != nil {
-		sm.log.Error("failed to load service region information")
-		sm.errorHandler.Handle(err)
 		return
 	}
 
@@ -266,8 +264,7 @@ func (sm *scrapingManager) scrapePricesInRegion(ctx context.Context, region stri
 	prices, err := sm.infoer.GetCurrentPrices(region)
 	if err != nil {
 		sm.metrics.ReportScrapeShortLivedFailure(sm.provider, region)
-		sm.log.Error("failed to scrape spot prices in region")
-		sm.errorHandler.Handle(err)
+		sm.log.WithFields(map[string]interface{}{"error": err, "provider": sm.provider, "region": region}).Error("failed to scrape spot prices in region")
 	}
 
 	for instType, price := range prices {
@@ -288,8 +285,7 @@ func (sm *scrapingManager) scrapePricesInAllRegions(ctx context.Context) {
 	start := time.Now()
 	regions, err := sm.infoer.GetRegions("compute")
 	if err != nil {
-		sm.log.Error("failed to retrieve regions")
-		sm.errorHandler.Handle(err)
+		sm.log.WithFields(map[string]interface{}{"error": err, "provider": sm.provider}).Error("failed to retrieve regions")
 	}
 
 	for regionId := range regions {