Fix: exclude hidden directories when drag-dropping folders into virtualTabs panel#45
Merged
Merged
Conversation
…-drop Agent-Logs-Url: https://github.com/winterdrive/vscode-virtual-tabs/sessions/006c1e08-f3d7-4853-9d32-f692a1c9d096 Co-authored-by: winterdrive <90021888+winterdrive@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix drag and drop behavior for hidden folders in virtualtabs panel
Fix: exclude hidden files/folders when drag-dropping directories into virtualTabs panel
May 12, 2026
Owner
|
@copilot 應該是只忽略 “.” 開頭的folder,而非連檔案也要忽略,這樣會導致.gitignore或其他可用檔案直接被忽略。我的理解是否正確,請正反兩面評價。 |
… expansion Agent-Logs-Url: https://github.com/winterdrive/vscode-virtual-tabs/sessions/73200347-ea31-4051-9259-cc7ff190fca0 Co-authored-by: winterdrive <90021888+winterdrive@users.noreply.github.com>
Contributor
Author
你的理解是正確的。以下是兩面評估: 只忽略隱藏資料夾(建議採用)
同時忽略隱藏檔案與資料夾
已在 |
Copilot
AI
changed the title
Fix: exclude hidden files/folders when drag-dropping directories into virtualTabs panel
Fix: exclude hidden directories when drag-dropping folders into virtualTabs panel
May 12, 2026
…s for scope management logic - Implemented E2E tests for Scope Filter UI behavior covering various scenarios including built-in and repo scopes. - Added unit tests for addGroup scope decision logic to ensure correct behavior based on active scopes. - Created tests for built-in group initialization conditions to verify proper handling of existing user groups. - Developed migration tests for transitioning from single to multiple active scopes. - Added tests for computing scope descriptions based on active scopes. - Implemented tests for root tree structure after applying scope filters to validate node types and order. - Updated existing tests to reflect changes in the visibility of the Add Group button in multi-root workspaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dragging a folder from VS Code's native tree view into the virtualTabs panel, hidden directories (
.git,.github, etc.) were recursively included — inconsistent with how VS Code's explorer displays file trees.Changes
src/dragAndDrop.ts— Added a guard ingetFilesInDirectoryRecursiveto skip directories whose names start with'.'. Hidden files (e.g..gitignore,.editorconfig) are still included, matching VS Code's native explorer behaviour which only excludes hidden folders like.gitby default:src/test/unit/dragAndDropHiddenFiles.test.ts— Unit tests covering: hidden directories are excluded, hidden files (.gitignore,.editorconfig) are retained, nested children of hidden dirs are excluded, normal files are unaffected, and edge cases (empty dir, dir containing only hidden entries).