Fixes #13962: fi can be nullptr (cppcheck-opensource#7623)

autoantwort · winterz · commit f4c5d90924d1 · 2025-06-30T15:25:55.000-04:00
diff --git a/lib/cppcheck.cpp b/lib/cppcheck.cpp
@@ -2089,9 +2089,10 @@ unsigned int CppCheck::analyseWholeProgram(const std::string &buildDir, const st
             // cppcheck-suppress shadowFunction - TODO: fix this
             for (const Check *check : Check::instances()) {
                 if (checkClassAttr == check->name()) {
-                    Check::FileInfo* fi = check->loadFileInfoFromXml(e);
-                    fi->file0 = filesTxtInfo.sourceFile;
-                    fileInfoList.push_back(fi);
+                    if (Check::FileInfo* fi = check->loadFileInfoFromXml(e)) {
+                        fi->file0 = filesTxtInfo.sourceFile;
+                        fileInfoList.push_back(fi);
+                    }
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -2089,9 +2089,10 @@ unsigned int CppCheck::analyseWholeProgram(const std::string &buildDir, const st`
`2089`	`2089`	`// cppcheck-suppress shadowFunction - TODO: fix this`
`2090`	`2090`	`for (const Check *check : Check::instances()) {`
`2091`	`2091`	`if (checkClassAttr == check->name()) {`
`2092`		`- Check::FileInfo* fi = check->loadFileInfoFromXml(e);`
`2093`		`- fi->file0 = filesTxtInfo.sourceFile;`
`2094`		`- fileInfoList.push_back(fi);`
	`2092`	`+ if (Check::FileInfo* fi = check->loadFileInfoFromXml(e)) {`
	`2093`	`+ fi->file0 = filesTxtInfo.sourceFile;`
	`2094`	`+ fileInfoList.push_back(fi);`
	`2095`	`+ }`
`2095`	`2096`	`}`
`2096`	`2097`	`}`
`2097`	`2098`	`}`